Merge pull request #419 from wp-cli/improve-multiple-theme-install-warning

ernilambar · web-flow · commit 5dcbb5e174dd · 2024-04-26T16:42:46.000+05:45
Improve warning message for install and activate multiple themes
diff --git a/features/theme-install.feature b/features/theme-install.feature
@@ -109,6 +109,19 @@ Feature: Install WordPress themes
   Scenario: Installation of multiple themes with activate
     When I try `wp theme install twentytwelve twentyeleven --activate`
     Then STDERR should contain:
-    """
-    Warning: Only a single theme can be active.
-    """
+      """
+      Warning: Only this single theme will be activated: twentyeleven
+      """
+
+    When I run `wp theme list --field=name`
+    Then STDOUT should contain:
+      """
+      twentyeleven
+      twentytwelve
+      """
+
+    When I run `wp theme list --field=name --status=active`
+    Then STDOUT should contain:
+      """
+      twentyeleven
+      """
diff --git a/src/Theme_Command.php b/src/Theme_Command.php
@@ -489,7 +489,8 @@ protected function filter_item_list( $items, $args ) {
 	 */
 	public function install( $args, $assoc_args ) {
 		if ( count( $args ) > 1 && Utils\get_flag_value( $assoc_args, 'activate', false ) ) {
-			WP_CLI::warning( 'Only a single theme can be active.' );
+			WP_CLI::warning( sprintf( 'Only this single theme will be activated: %s', end( $args ) ) );
+			reset( $args );
 		}
 
 		$theme_root = get_theme_root();

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,8 @@ protected function filter_item_list( $items, $args ) {`
`489`	`489`	`*/`
`490`	`490`	`public function install( $args, $assoc_args ) {`
`491`	`491`	`if ( count( $args ) > 1 && Utils\get_flag_value( $assoc_args, 'activate', false ) ) {`
`492`		`- WP_CLI::warning( 'Only a single theme can be active.' );`
	`492`	`+ WP_CLI::warning( sprintf( 'Only this single theme will be activated: %s', end( $args ) ) );`
	`493`	`+ reset( $args );`
`493`	`494`	`}`
`494`	`495`
`495`	`496`	`$theme_root = get_theme_root();`