You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the RecursiveDataStructureTraverser class from the wp-cli/entity-command package and sets the package up to reuse it from the framework instead.
Note: Pushing first with the removal only to show how it fails before fixing the distribution aspect of it.
@danielbachhuber , @swissspidy some added context here to explain how this works:
The new \WP_CLI\Traverser\RecursiveDataStructureTraverser in the framework is not yet part of a tagged release, it is only included in the main branch so far.
However, given that:
the stability requirements of this package have been set to dev =>
... we can tell Composer to pull in version 2.10+ of the framework. It will accept dev-main to represent a non-stable version of 2.10, and the dev stability requirements will allow that version to be used for wp-cli/entity-command's requirements => a6d96ee#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R15
This effectively means that the wp-cli/entity-command will pull in dev-main and assume it is v2.10+ (and all other packages have been set up to work correctly with this).
Then, once we will release a tagged version 2.10.0 for the wp-cli/wp-cli framework, the fact that the wp-cli/entity-command has prefer-stable set to true means that it will revert back to a stable, tagged version of 2.10.0 and all future versions as soon as possible =>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
RecursiveDataStructureTraverser
class from thewp-cli/entity-command
package and sets the package up to reuse it from the framework instead.Note: Pushing first with the removal only to show how it fails before fixing the distribution aspect of it.