Merge pull request #469 from ernilambar/464-fix-comment-recount

swissspidy · web-flow · commit be561cf574cb · 2024-02-14T09:26:02.000+01:00
diff --git a/features/comment-recount.feature b/features/comment-recount.feature
@@ -23,3 +23,9 @@ Feature: Recount comments on a post
       """
       Updated post 1 comment count to 3.
       """
+
+    When I try `wp comment recount 99999999`
+    Then STDERR should be:
+      """
+      Warning: Post 99999999 doesn't exist.
+      """
diff --git a/src/Comment_Command.php b/src/Comment_Command.php
@@ -672,12 +672,11 @@ public function count( $args, $assoc_args ) {
 	 */
 	public function recount( $args ) {
 		foreach ( $args as $id ) {
-			wp_update_comment_count( $id );
-			$post = get_post( $id );
-			if ( $post ) {
+			if ( wp_update_comment_count( $id ) ) {
+				$post = get_post( $id );
 				WP_CLI::log( "Updated post {$post->ID} comment count to {$post->comment_count}." );
 			} else {
-				WP_CLI::warning( "Post {$post->ID} doesn't exist." );
+				WP_CLI::warning( "Post {$id} doesn't exist." );
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -672,12 +672,11 @@ public function count( $args, $assoc_args ) {`
`672`	`672`	`*/`
`673`	`673`	`public function recount( $args ) {`
`674`	`674`	`foreach ( $args as $id ) {`
`675`		`- wp_update_comment_count( $id );`
`676`		`- $post = get_post( $id );`
`677`		`- if ( $post ) {`
	`675`	`+ if ( wp_update_comment_count( $id ) ) {`
	`676`	`+ $post = get_post( $id );`
`678`	`677`	`WP_CLI::log( "Updated post {$post->ID} comment count to {$post->comment_count}." );`
`679`	`678`	`} else {`
`680`		`- WP_CLI::warning( "Post {$post->ID} doesn't exist." );`
	`679`	`+ WP_CLI::warning( "Post {$id} doesn't exist." );`
`681`	`680`	`}`
`682`	`681`	`}`
`683`	`682`	`}`