You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we dont have should contain a table containing rows. Regarding table we have should be a table containing rows and should end with a table containing rows. Both conditions are not applicable in this case.
Our output would be like this:
Starting update...
Unpacking the update...
Cleaning up files...
No files found that need cleaning up.
name old_version new_version status
core 6.0 6.1 Updated
Success: WordPress updated successfully.
@schlessera Any suggestion how we can implement test for table in this case?
Or, should be implement quiet logger for table also?
Looks like should end with a table containing rows does not necessarily check the table in the end. May be we should introduce should contain a table containing rows and also fix this feature context.
I would lean towards implementing the quiet logger for table output too.
And I can confirm ThenStepDefinitions::then_stdout_should_end_with_a_table_containing_rows() does not test that the table is at the end of the output. It searches stdout for the table header and checks the remainder of stdout for the expected rows. It would be somewhat more accurately named then_stdout_should_contain_a_table_containing_rows, but if output contained two tables, it could incorrectly pass if the second table coincidentally contained the row values that were expected in the first table.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129