You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Can we make sure there are GitHub issues open for the TODO comments? They will probably be forgotten otherwise.
Also, I'm a little bit wary of all of the @require-mysql statements because it means we're skipping the tests for SQLite. I don't think it necessarily blocks this, but we might want to track it in some way.
Also, I'm a little bit wary of all of the @require-mysql statements because it means we're skipping the tests for SQLite. I don't think it necessarily blocks this, but we might want to track it in some way.
Another potential way to solve this: create a custom Matrix for the SQLite tests, and only run SQLite for WordPress 6.0 and higher. I think this would be my recommended approach.
Another potential way to solve this: create a custom Matrix for the SQLite tests, and only run SQLite for WordPress 6.0 and higher.
This is already the case, actually. What's happening here is that some individual scenarios downgrade to WordPress 4.0 and then upgrade to the latest version.
Can we make sure there are GitHub issues open for the TODO comments? They will probably be forgotten otherwise.
Totally. The only TODO that doesn't have one yet is the one about CUSTOM_USER_TABLE. I'm not yet sure whether it's an issue with the command or the SQLite plugin.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242