[css-inline-3] Expand tests for text-box* parsing and computation

fantasai · fantasai · commit d85c6acff291 · 2024-08-14T14:01:19.000-04:00
diff --git a/css/css-inline/text-box-trim/parsing/inheritance.html b/css/css-inline/text-box-trim/parsing/inheritance.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<title>Inheritance of CSS Inline Layout properties</title>
+<title>Inheritance of CSS Inline Layout Text Edge Properties</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge">
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim">
 <script src="/resources/testharness.js"></script>
@@ -9,6 +9,6 @@
   <div id="target"></div>
 </div>
 <script>
-assert_inherited('text-box-edge', 'auto', 'text');
+assert_not_inherited('text-box-edge', 'auto', 'text');
 assert_not_inherited('text-box-trim', 'none', 'trim-start');
 </script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-computed.html b/css/css-inline/text-box-trim/parsing/text-box-computed.html
@@ -1,4 +1,5 @@
 <!DOCTYPE html>
+<title>text-box getComputedStyle() returns correctly resolved values</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-edge-computed.html b/css/css-inline/text-box-trim/parsing/text-box-edge-computed.html
@@ -1,8 +1,6 @@
 <!DOCTYPE html>
-<title>Tests parsing of the text-box-edge property</title>
-<link rel="author" title="Google LLC" href="https://www.google.com/">
+<title>text-box getComputedStyle() returns correctly resolved values</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#text-edges">
-<meta name="assert" content="text-box-edge supports the full grammar leading | [ text | cap | ex | ideographic | ideographic-ink ] [ text | alphabetic | ideographic | ideographic-ink ]">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/computed-testcommon.js"></script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-edge-invalid.html b/css/css-inline/text-box-trim/parsing/text-box-edge-invalid.html
@@ -1,17 +1,20 @@
 <!DOCTYPE html>
-<title>Tests parsing of the text-box-edge property</title>
-<link rel="author" title="Google LLC" href="https://www.google.com/">
+<title>text-box-edge rejects invalid values</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#text-edges">
-<meta name="assert" content="text-box-edge supports the full grammar leading | [ text | cap | ex | ideographic | ideographic-ink ] [ text | alphabetic | ideographic | ideographic-ink ]">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/parsing-testcommon.js"></script>
 
 <script>
 // invalid keyword
+
+test_invalid_value('text-box-edge', 'none');
+test_invalid_value('text-box-edge', 'normal');
 test_invalid_value('text-box-edge', 'leading');
 test_invalid_value('text-box-edge', 'auto leading');
 test_invalid_value('text-box-edge', 'leading auto');
+test_invalid_value('text-box-edge', 'normal text');
+test_invalid_value('text-box-edge', 'text none');
 
 // invalid grammar
 test_invalid_value('text-box-edge', 'alphabetic');
diff --git a/css/css-inline/text-box-trim/parsing/text-box-edge-valid.html b/css/css-inline/text-box-trim/parsing/text-box-edge-valid.html
@@ -1,8 +1,6 @@
 <!DOCTYPE html>
-<title>Tests parsing of the text-box-edge property</title>
-<link rel="author" title="Google LLC" href="https://www.google.com/">
+<title>text-box-edge parses valid values according to its grammar</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#text-edges">
-<meta name="assert" content="text-box-edge supports the full grammar leading | [ text | cap | ex | ideographic | ideographic-ink ] [ text | alphabetic | ideographic | ideographic-ink ]">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/parsing-testcommon.js"></script>
@@ -12,7 +10,10 @@
 test_valid_value('text-box-edge', 'text');
 test_valid_value('text-box-edge', 'ex');
 test_valid_value('text-box-edge', 'cap');
+test_valid_value('text-box-edge', 'ideographic');
+test_valid_value('text-box-edge', 'ideographic-ink');
 test_valid_value('text-box-edge', 'text alphabetic');
+test_valid_value('text-box-edge', 'ideographic text');
 test_valid_value('text-box-edge', 'text text', 'text');
 test_valid_value('text-box-edge', 'cap alphabetic');
 test_valid_value('text-box-edge', 'cap text', 'cap');
diff --git a/css/css-inline/text-box-trim/parsing/text-box-invalid.html b/css/css-inline/text-box-trim/parsing/text-box-invalid.html
@@ -1,4 +1,5 @@
 <!DOCTYPE html>
+<title>text-box rejects invalid values</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
@@ -7,8 +8,19 @@
 <script>
 // invalid keyword
 test_invalid_value('text-box', 'em');
+test_invalid_value('text-box', 'leading');
+test_invalid_value('text-box', 'trim-both leading');
+
+// invalid grammars
+text_invalid_value('text-box', 'normal normal');
+test_invalid_value('text-box', 'normal none');
+text_invalid_value('text-box', 'auto normal');
 test_invalid_value('text-box', 'normal text');
 test_invalid_value('text-box', 'text normal');
-test_invalid_value('text-box', 'auto leading');
-test_invalid_value('text-box', 'leading auto');
+text_invalid_value('text-box', 'alphabetic text');
+text_invalid_value('text-box', 'alphabetic cap');
+text_invalid_value('text-box', 'cap none alphabetic');
+text_invalid_value('text-box', 'cap trim-both alphabetic');
+text_invalid_value('text-box', 'text none text');
+text_invalid_value('text-box', 'text trim-both text');
 </script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-shorthand.html b/css/css-inline/text-box-trim/parsing/text-box-shorthand.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<meta charset="utf-8">
+<title>text-box shorthand defaults omitted values per spec</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-trim-computed.html b/css/css-inline/text-box-trim/parsing/text-box-trim-computed.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<title>Tests parsing of the text-box-trim property</title>
+<title>text-box getComputedStyle() returns correctly resolved values</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-trim-valid.html b/css/css-inline/text-box-trim/parsing/text-box-trim-valid.html
@@ -1,4 +1,5 @@
 <!DOCTYPE html>
+<title>text-box-trim parses valid values according to its grammar</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#leading-trim">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/css/css-inline/text-box-trim/parsing/text-box-valid.html b/css/css-inline/text-box-trim/parsing/text-box-valid.html
@@ -1,30 +1,44 @@
 <!DOCTYPE html>
+<title>text-box parses valid values according to its grammar</title>
 <link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/parsing-testcommon.js"></script>
 
 <script>
-// `normal | <text-box-trim> || <text-box-edge>`
+// initial values
 test_valid_value('text-box', 'normal');
+test_valid_value('text-box', 'none', 'normal');
+test_valid_value('text-box', 'auto', 'normal');
+test_valid_value('text-box', 'none auto', 'normal');
+test_valid_value('text-box', 'auto none', 'normal');
 
 // `<text-box-trim>`: `none | trim-start | trim-end | trim-both`
-test_valid_value('text-box', 'none', 'normal');
 test_valid_value('text-box', 'trim-start');
 test_valid_value('text-box', 'trim-end');
 test_valid_value('text-box', 'trim-both');
 
-// `<text-box-edge>`: `auto | <text-edge>`
-test_valid_value('text-box', 'none auto', 'normal');
-test_valid_value('text-box', 'trim-start auto', 'trim-start');
-test_valid_value('text-box', 'trim-both auto', 'trim-both');
-
 // `<text-edge>`
 test_valid_value('text-box', 'text');
+test_valid_value('text-box', 'cap');
+test_valid_value('text-box', 'ideographic');
 test_valid_value('text-box', 'cap alphabetic');
+test_valid_value('text-box', 'text alphabetic');
+
+// Mix initial and non-initial values
+test_valid_value('text-box', 'trim-start auto', 'trim-start');
+test_valid_value('text-box', 'auto trim-both', 'trim-both');
+test_valid_value('text-box', 'none text', 'none text');
+test_valid_value('text-box', 'text text none', 'none text');
+test_valid_value('text-box', 'none cap', 'none cap');
+test_valid_value('text-box', 'cap ideographic none', 'none cap ideographic');
+test_valid_value('text-box', 'ideographic none', 'none ideographic');
 
 // Both `<text-box-trim>` and `<text-box-edge>`
 test_valid_value('text-box', 'trim-both text', 'text');
 test_valid_value('text-box', 'trim-start text');
-test_valid_value('text-box', 'trim-start cap alphabetic');
+test_valid_value('text-box', 'text text trim-both', 'text');
+test_valid_value('text-box', 'text text trim-end', 'trim-end');
+test_valid_value('text-box', 'cap alphabetic trim-start', 'trim-start cap alphabetic');
+test_valid_value('text-box', 'trim-both cap alphabetic', 'cap alphabetic');
 </script>

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<!DOCTYPE html>`
	`2`	`+<title>text-box getComputedStyle() returns correctly resolved values</title>`
`2`	`3`	`<link rel="help" href="https://drafts.csswg.org/css-inline-3/#propdef-text-box">`
`3`	`4`	`<script src="/resources/testharness.js"></script>`
`4`	`5`	`<script src="/resources/testharnessreport.js"></script>`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<!DOCTYPE html>`
	`2`	`+<title>text-box-trim parses valid values according to its grammar</title>`
`2`	`3`	`<link rel="help" href="https://drafts.csswg.org/css-inline-3/#leading-trim">`
`3`	`4`	`<script src="/resources/testharness.js"></script>`
`4`	`5`	`<script src="/resources/testharnessreport.js"></script>`