You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 11, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual HTML that's used on this page doesn't follow the page's own advice about using td elements (rather than th elements) when the cell is empty.
This pull request updates that code so it's consistent with the code snippet
More investigation/work is needed here because once the element is changed to a <td> we lose the background colour. Design-wise it would be good to keep that colour for the header rows/columns even if blank.
That said, just for reference, on other pages on the production site, like https://www.w3.org/WAI/tutorials/tables/two-headers/, td's are being used in a similar way to how it's used in this pull request. For example:
If it's important to keep the styling of the th in this pull request, one idea could be to create a .th class, that could be added to the td element, like:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready to mergePR is ready to merge but need to wait for appropriate time
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual HTML that's used on this page doesn't follow the page's own advice about using
td
elements (rather thanth
elements) when the cell is empty.This pull request updates that code so it's consistent with the code snippet