CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 7
First draft for placeholder #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As discussed in issue #688
Just on a skim this looks fine, but it's a headache to implement to test. If I switch over to placeholders, either I have to duplicate the code to continue to account for the 2.0 files or I'm back to only being able to display English. We should try and hurry this revision along after adding, perhaps not taking up any additional issues, so we can deprecate 2.0 and get the translations updated. |
One issue I noticed that's not directly covered here is the certifier's report. The algorithm says to replace the entire string with a hyperlink, but the examples in the guidelines show only the words "certifier's report" hyperlinked. The guidelines approach makes more sense, but is there a way to accommodate that with a placeholder since it's not possible to know what words to hyperlink in any other language. (edit: changed last sentence from suggesting percent sign to bracket since we are using braces.) |
<li>display <code id="accessibility-summary-publisher-contact">"For more information about the accessibility of this product, please contact the publisher: "</code></li> | ||
<li>display <var>publisher_contact_for_accessibility</var> as link <b>IF</b> <var>publisher_contact_for_accessibility</var> is an email address.</li> | ||
</ol> | ||
<span><b>THEN</b> display <code id="accessibility-summary-publisher-contact">"For more information about the accessibility of this product, please contact the publisher: {publisher_contact_for_accessibility}"</code> replacing <code>"{publisher_contact_for_accessibility}"</code> with <var>publisher_contact_for_accessibility</var> as link <b>IF</b> <var>publisher_contact_for_accessibility</var> is an email address.</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be obvious, but it might be better to say to replace with a "mailto link" here.
<span><b>THEN</b> display <code id="accessibility-summary-publisher-contact">"For more information about the accessibility of this product, please contact the publisher: {publisher_contact_for_accessibility}"</code> replacing <code>"{publisher_contact_for_accessibility}"</code> with <var>publisher_contact_for_accessibility</var> as link <b>IF</b> <var>publisher_contact_for_accessibility</var> is an email address.</span> | |
<span><b>THEN</b> display <code id="accessibility-summary-publisher-contact">"For more information about the accessibility of this product, please contact the publisher: {publisher_contact_for_accessibility}"</code> replacing <code>"{publisher_contact_for_accessibility}"</code> with <var>publisher_contact_for_accessibility</var> as a mailto link.</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can the last "IF ... is an email address." be dropped? Doesn't onix require an email address?
I've finished implementing this now. The only other slightly tangential comment I have is that maybe we should say something about localizing the date, not just to replace the placeholder with whatever value you get from the metadata. No matter the language it may need some processing, if not to turn the date into the local language then to process out an attached time. It could just go in the variable setup description, but it's a unique case of localizing the publisher data. |
As discussed in issue #688