| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 17 Jul 2025 08:28:34 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
etag: W/"1a8bb962bc8bca0d3a71973755316041"
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=GzRNqprMdGUHazZJRM42hcfZOm0ysGIzOWtc0V9BFGYdBS%2BuArOTpqZXVnBs6vjmkgF0BEQmPMolYN%2BrqN3McLD1l4SKYCUFVc1nbOTBK5QPS5LR%2FJ7LjrU1Q4FkpAiCP3k%2B2GucBMe1pX%2BTXPzEYfyrlVZ2Rca3%2FEeng8sjEUZX%2BYgKlLtstjpCDQ0GOIE8JUJs6AnMYkuJtgcGzoJJ%2BdAh32Q9tWflXwOqYpINXzEqtaq1tZbc7NxIwGyMc2AToRq6ITtGgOOvWM5Vy%2Bm2QA%3D%3D--HCS9bR2DFYzfZsMP--9ADYnItiT17pWeWFhd5wug%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.476018318.1752740913; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 08:28:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 08:28:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE36:1E4F6:55093D:65A993:6878B431
Proposal ONIX technique for Charts, diagrams, and formulas by gregoriopellegrino · Pull Request #257 · w3c/publ-a11y · GitHub
gregoriopellegrino
requested review from
GeorgeKerscher,
avneeshsingh,
gautierchomel and
clapierre
March 27, 2024 14:49
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 7
Proposal ONIX technique for Charts, diagrams, and formulas #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoriopellegrino
requested review from
GeorgeKerscher,
avneeshsingh,
gautierchomel and
clapierre
clapierre
reviewed
Mar 27, 2024
| <li><b>LET</b> <var>real_text</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail/PrimaryContentType[text() = "10"]</code> <b>OR</b> the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail/ProductContentType[text() = "10"]</code>.</li> | ||
| <li><b>LET</b> <var>non_textual_content_still</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail/PrimaryContentType[text() = "07" or text() = "18" or text() = "19" or text() = "12" or text() = "49" or text() = "20"]</code> <b>OR</b> the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail/ProductContentType[text() = "07" or text() = "18" or text() = "19" or text() = "12" or text() = "49" or text() = "20"]</code>.</li> | ||
| <li><b>LET</b> <var>real_text</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail[PrimaryContentType = "10" or ProductContentType = "10"]</code>.</li> | ||
| <li><b>LET</b> <var>non_textual_content_still</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail[PrimaryContentType = "07" or PrimaryContentType = "18" or PrimaryContentType = "19" or PrimaryContentType = "12" or PrimaryContentType = "49" or PrimaryContentType = "20" or ProductContentType = "07" or ProductContentType = "18" or ProductContentType = "19" or ProductContentType = "12" or ProductContentType = "49" or ProductContentType = "20"]</code>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going to change non_textual_content_still to something more descriptive. like non_textual_content_still_image ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I've updated the pull request based on Charles' suggestion and on comments during last call (check only for metadata declaring that accessible STEM content is present, without checking whether the publisher declares the presence of STEM content in the ebook). I would proceed with the merge. |
clapierre
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads much better thanks Gregorio.
|
Looks good overall. Minor suggestion: plural or singular? We have a mix. Charts, images, diagrams, but formula. Having even one in the book makes the adaptation necessary but maybe it reads better if all are plural? |
|
It does look good.
If we go for plural of formula - have to decide if use formulae or formulas.
I have used formulae in the suggested text but formulas is equally good.
Christopher Saynor
EDItEUR
United House, North Road
London N7 9DP
UK
Tel: +44 20 7503 6418
The information contained in this e-mail is confidential and may be privileged. It is intended for the addressee only. If you are not the intended recipient, please inform the sender and delete this e-mail immediately. The contents of this e-mail must not be disclosed or copied without the sender's consent. We cannot accept any responsibility for viruses, so please scan all attachments. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of the company.
EDItEUR Limited is a company limited by guarantee, registered in England no 2994705. Registered Office: United House, North Road, London N7 9DP, UK. Website: https://www.editeur.org
For Thema codes https://ns.editeur.org/thema/
For ONIX codes https://ns.editeur.org/onix/
On 3 Apr 2024, at 15:42, Madeleine Rothberg ***@***.***> wrote:
Looks good overall. Minor suggestion: plural or singular? We have a mix. Charts, images, diagrams, but formula. Having even one in the book makes the adaptation necessary but maybe it reads better if all are plural?
—
Reply to this email directly, view it on GitHub<#257 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5R4HEAHQYYGCPY43CU76ALY3QIO3AVCNFSM6AAAAABFLA75UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUHAYTSMRRGU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
gautierchomel
approved these changes
Apr 3, 2024
|
Yes, I was wondering about formulae vs formulas. Quick check online suggests that "ae" is used in scientific contexts and is also more common in British English. We are currently using "color" not "colour" which suggests we are using American spelling rules. Who is our supreme authority on copyedit rules? (Joking, but we do need a way to make decisions.) |
|
This looks good. I will merge. |
If we make a decision, I will proceed with the changes. |
|
My vote would be for US English. Of course, that is where I live Do we change the lange attribute to en-us? It seems reasonable and will be important for the localizations. Best |
|
We use US-english for ONIX by default - even if we are based in the UK - I would say use what is understandable to the majority of users
Christopher Saynor
EDItEUR
United House, North Road
London N7 9DP
UK
Tel: +44 20 7503 6418
The information contained in this e-mail is confidential and may be privileged. It is intended for the addressee only. If you are not the intended recipient, please inform the sender and delete this e-mail immediately. The contents of this e-mail must not be disclosed or copied without the sender's consent. We cannot accept any responsibility for viruses, so please scan all attachments. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of the company.
EDItEUR Limited is a company limited by guarantee, registered in England no 2994705. Registered Office: United House, North Road, London N7 9DP, UK. Website: https://www.editeur.org
For Thema codes https://ns.editeur.org/thema/
For ONIX codes https://ns.editeur.org/onix/
On 4 Apr 2024, at 14:41, George ***@***.***> wrote:
My vote would be for US English. Of course, that is where I live Do we change the lange attribute to en-us? It seems reasonable and will be important for the localizations.
Best
George
—
Reply to this email directly, view it on GitHub<#257 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5R4HEGXB2UAB7CLDHNY4LLY3VKCNAVCNFSM6AAAAABFLA75UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGI2TSNZZGU>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Sorry, since I am neither British English nor American English, could you please point me to the changes that need to be made? Thank you 😀 |
|
The consensus is to use the US English version of the plural of formula - that is formulas.
So if the word ‘formulae’ is present please replace this with ‘formulas’
Thank you
Christopher Saynor
EDItEUR
United House, North Road
London N7 9DP
UK
Tel: +44 20 7503 6418
The information contained in this e-mail is confidential and may be privileged. It is intended for the addressee only. If you are not the intended recipient, please inform the sender and delete this e-mail immediately. The contents of this e-mail must not be disclosed or copied without the sender's consent. We cannot accept any responsibility for viruses, so please scan all attachments. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of the company.
EDItEUR Limited is a company limited by guarantee, registered in England no 2994705. Registered Office: United House, North Road, London N7 9DP, UK. Website: https://www.editeur.org
For Thema codes https://ns.editeur.org/thema/
For ONIX codes https://ns.editeur.org/onix/
On 8 Apr 2024, at 07:39, Gregorio Pellegirno ***@***.***> wrote:
Sorry, since I am neither British English nor American English, could you please point me to the changes that need to be made?
Thank you 😀
—
Reply to this email directly, view it on GitHub<#257 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5R4HEH6TGMJACUD26QXBY3Y4I3RXAVCNFSM6AAAAABFLA75UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRHE3TANJVGA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Thanks to Chris here is the proposal for the ONIX technique for "Charts, diagrams, and formulas"