You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support button presses on a hovering stylus, button and buttons shouldn't require a pen contact when barrel/eraser buttons are pressed. This change makes pen buttons independent of pen contact.
Note that contact independent button/buttons values cause subtle changes in active button state.
LGTM (and ignore the remaining note/discussion about hovering click, as I think that's sufficiently addressed in current wording and not exactly standard anyway).
The reason will be displayed to describe this comment to others. Learn more.
Pen moved while hovering with no buttons pressed
Note that "moved" here includes the cases when the "footprint" of the pen is unmoved: e.g. a change in twist. I think the pen still must move physically to generate an event, so this is fine.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support button presses on a hovering stylus, button and buttons shouldn't require a pen contact when barrel/eraser buttons are pressed. This change makes pen buttons independent of pen contact.
Note that contact independent button/buttons values cause subtle changes in active button state.
Closes #14.