Fix #91. Make all pointer events composed events #92

hayatoito · 2016-06-21T03:45:36Z

All pointer events should propagate across Shadow DOM bounaries.
See WICG/webcomponents#513 for details.

patrickhlauke · 2016-06-21T09:59:08Z

as I'm not completely au-fait with what composed events actually are/do, nor if there are any issues with a W3C spec referencing WHATWG (political or otherwise) ... @RByers, thoughts?

RByers · 2016-06-21T19:43:03Z

I suggest we wait until UIEvents has been updated for this before trying to review a PR for PointerEvents (since we mostly just copy the patterns from UI Events here).

hayatoito · 2016-06-28T01:44:53Z

@RByers

PR for UI events has been merged w3c/uievents#91.
Could you have a chance to review this PR for Pointer Events?

RByers · 2016-06-29T17:40:43Z

index.html

                <p>To <dfn>fire a pointer event name e</dfn> means to <dfn>fire an event named e</dfn> as defined in [[!DOM4]] with an event using the <a>PointerEvent</a> interface whose attributes are set as defined in <a href="#pointerevent-interface"><code>PointerEvent</code> Interface</a>.</p>

-                <p>Initialize the <code>bubbles</code> attribute for the event to <code>true</code> if the event name is</p>
+                <p>Initialize the <code>bubbles</code> attribute and the <code>composed</code> [[!WHATWG-DOM]] attribute for the event to <code>true</code> if the event name is</p>


The below list doesn't include pointerenter or pointerleave but you want those to be composed, right? I suggest moving the text for composed up to the above sentence so that it applies to all pointer events.

Good catch! Done.

RByers · 2016-06-29T18:08:57Z

Oh, this is non-trivial enough that you should probably also add an entry to the revision history.

All pointer events should propagate across Shadow DOM bounaries. See WICG/webcomponents#513 for details.

hayatoito · 2016-06-30T06:26:54Z

Oh, this is non-trivial enough that you should probably also add an entry to the revision history.

Thanks! I have added an entry to the revision history.

I have squashed the commits. Could you review PR again?

patrickhlauke · 2016-06-30T07:05:36Z

LGTM

hayatoito mentioned this pull request Jun 21, 2016

Support Event.composed in Pointer Events #91

Closed

patrickhlauke assigned RByers Jun 21, 2016

RByers reviewed Jun 29, 2016
View reviewed changes

Fix w3c#91. Make all pointer events composed events

084907c

All pointer events should propagate across Shadow DOM bounaries. See WICG/webcomponents#513 for details.

hayatoito force-pushed the composed branch from 482e3d1 to 084907c Compare June 30, 2016 06:24

patrickhlauke merged commit be54665 into w3c:gh-pages Jun 30, 2016

hayatoito mentioned this pull request Jun 30, 2016

Support Event.composed w3c/uievents#89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #91. Make all pointer events composed events #92

Fix #91. Make all pointer events composed events #92

Uh oh!

hayatoito commented Jun 21, 2016

Uh oh!

patrickhlauke commented Jun 21, 2016

Uh oh!

RByers commented Jun 21, 2016

Uh oh!

hayatoito commented Jun 28, 2016

Uh oh!

RByers Jun 29, 2016

Uh oh!

hayatoito Jun 30, 2016

Uh oh!

RByers commented Jun 29, 2016

Uh oh!

hayatoito commented Jun 30, 2016

Uh oh!

patrickhlauke commented Jun 30, 2016

Uh oh!

Uh oh!

Fix #91. Make all pointer events composed events #92

Fix #91. Make all pointer events composed events #92

Uh oh!

Conversation

hayatoito commented Jun 21, 2016

Uh oh!

patrickhlauke commented Jun 21, 2016

Uh oh!

RByers commented Jun 21, 2016

Uh oh!

hayatoito commented Jun 28, 2016

Uh oh!

RByers Jun 29, 2016

Choose a reason for hiding this comment

Uh oh!

hayatoito Jun 30, 2016

Choose a reason for hiding this comment

Uh oh!

RByers commented Jun 29, 2016

Uh oh!

hayatoito commented Jun 30, 2016

Uh oh!

patrickhlauke commented Jun 30, 2016

Uh oh!

Uh oh!