Add persistentDeviceId to PointerEvent #495

sahirv · 2024-01-11T21:51:49Z

This change proposes the introduction of a new attribute to the PointerEvent interface - persistentDeviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

This pull request is expected to make the 4th iteration of the PointerEvent specification.

Preview | Diff

This change proposes the introduction of a new attribute to the PointerEvent interface - deviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

patrickhlauke · 2024-01-17T16:40:05Z

Worth adding, for context, #353

sahirv · 2024-01-17T17:01:54Z

Happy to take any comments on the changes. The idea is based on that of pointer id; -1 is reserved for invalid ids. In Chromium, 1 is reserved for the mouse pointer (0 is unused); but I left the wording to be similar to the pointerId definition. As long as the deviceId is unique for each device, web devs should not have a problem.

index.html

sahirv · 2024-03-05T22:27:43Z

Made changes to introduce deviceProperties rather than having deviceId on PointerEvent. Rough draft- feedback appreciated

index.html

This change replaces deviceId on the PointerEvent interface with a new interface, deviceProperties. DeviceProperties contains one member, uniqueId, which functionally behaves the same as the outgoing deviceId. Spec: w3c/pointerevents#495 This change also removes the setting of deviceId when creating a PointerCancel event, as there is no current application for device/unique id for a PointerCancel. Bug: 330760871 Change-Id: I0f1a9f7d5589f790d94f498a38bfdf55b6f51073

… 0, a=testonly Automatic update from web-platform-tests Set Invalid DeviceProperties.uniqueId to 0 Replace -1 with 0 for the invalid uniqueId as per recent spec consensus. Spec: w3c/pointerevents#495 Bug: 330760871 Change-Id: I063515535ee0510c89942f16098c6211bafb480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463741 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1290720} -- wpt-commits: a2bf027ec76e7f183c4f7e3fdcd62d5a0e818598 wpt-pr: 45765

sahirv · 2024-06-10T17:05:14Z

@smaug---- @flackr @mustaqahmed I have updated this PR to introduce persistentDeviceId. Please take a look and leave your feedback. Thank you :)

sahirv · 2024-06-17T19:48:19Z

Gentle ping :)

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318886}

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellanimicrosoft.com> Reviewed-by: Olga Gerchikov <gerchikomicrosoft.com> Reviewed-by: Robert Flack <flackrchromium.org> Cr-Commit-Position: refs/heads/main{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888 UltraBlame original commit: 84225becd9d58cb4946fefdbbd42aeda5dc9445c

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888

patrickhlauke · 2024-07-04T13:47:34Z

repointed this PR to the new next branch

smaug---- · 2024-07-17T15:44:06Z

Looks like the tests rely on window.internals. What is that? And why are the non-manual tests passing in all the browsers even if the API isn't implemented. Could the tests be fixed?

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318886}

sahirv · 2024-07-18T17:12:57Z

Thanks for bringing the tests up! I'll look into it and report back here.

sahirv · 2024-07-29T16:49:23Z

The tests have been fixed.

patrickhlauke · 2024-08-14T15:02:05Z

Merged into the next version of the spec, as discussed here https://www.w3.org/2024/07/31-pointerevents-minutes.html#t03

… a=testonly Automatic update from web-platform-tests Introduce PointerEvent.deviceProperties This change replaces deviceId on the PointerEvent interface with a new interface, deviceProperties. DeviceProperties contains one member, uniqueId, which functionally behaves the same as the outgoing deviceId. Spec: w3c/pointerevents#495 Bug: 330760871 Change-Id: I0f1a9f7d5589f790d94f498a38bfdf55b6f51073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388651 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1286827} -- wpt-commits: 4013b5285c0977d16542695ae2ed47184730f331 wpt-pr: 45420

… 0, a=testonly Automatic update from web-platform-tests Set Invalid DeviceProperties.uniqueId to 0 Replace -1 with 0 for the invalid uniqueId as per recent spec consensus. Spec: w3c/pointerevents#495 Bug: 330760871 Change-Id: I063515535ee0510c89942f16098c6211bafb480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463741 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1290720} -- wpt-commits: a2bf027ec76e7f183c4f7e3fdcd62d5a0e818598 wpt-pr: 45765

…roperties in PointerEventInit, a=testonly Automatic update from web-platform-tests Set null as the default value of deviceProperties in PointerEventInit Previously, the default for deviceProperties in PointerEventInit was undefined; although in chromium a value was set using the default constructor. This CL changes this behaviour such that the default value for deviceProperties is null. The corresponding WPT is updated as well. For further context, please see the discussion here: w3c/pointerevents#495 (comment) Bug: 330760871 Change-Id: I5becf25f76e8b8c4572a783bfba8c1c4f36f8a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526091 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298623} -- wpt-commits: aec353e3b1cae190e1c0485b1406ea522f38e661 wpt-pr: 46174

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888

Add deviceId to PointerEvent spec

53aa55e

This change proposes the introduction of a new attribute to the PointerEvent interface - deviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

patrickhlauke added the v4 label Jan 17, 2024

flackr reviewed Jan 18, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

ogerchikov reviewed Jan 18, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Specify value of 1 for mouse events

abe761f

flackr mentioned this pull request Jan 23, 2024

Multi-pen support and persistent pointerId #353

Closed

Switch to deviceProperties

55a1acc

sahirv changed the title ~~Add deviceId to PointerEvent spec~~ Add deviceProperties.uniqueId to PointerEvent spec Mar 5, 2024

sahirv added 2 commits March 5, 2024 14:34

Fix example numbering

bcd5db0

Add some more details to uniqueId decription

06be8e0

ogerchikov reviewed Mar 5, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

ogerchikov reviewed Mar 5, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Add constructor

fe6a97d

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Address feedback

dd4ea5a

sahirv requested a review from flackr March 11, 2024 18:00

flackr reviewed Mar 20, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

Address feedback, add init dict

453da9f

flackr reviewed Mar 26, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

sahirv added 2 commits March 26, 2024 13:44

Fix example

b2d7e83

Fix default value in dict

eefea6e

chromium-wpt-export-bot mentioned this pull request Mar 28, 2024

Introduce PointerEvent.deviceProperties web-platform-tests/wpt#45420

Merged

Switch to persistentDeviceId

8853ccf

sahirv changed the title ~~Add deviceProperties.uniqueId to PointerEvent spec~~ Add persistentDeviceId to PointerEvent Jun 10, 2024

flackr approved these changes Jun 19, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Jun 24, 2024

Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId web-platform-tests/wpt#46888

Merged

patrickhlauke changed the base branch from gh-pages to next July 4, 2024 13:47

Elchi3 mentioned this pull request Jul 25, 2024

Add PointerEvent.deviceProperties openwebdocs/mdn-bcd-collector#1692

Merged

patrickhlauke changed the base branch from next to gh-pages August 14, 2024 12:55

patrickhlauke merged commit 3ec245e into w3c:gh-pages Aug 14, 2024

Add persistentDeviceId to PointerEvent #495

Add persistentDeviceId to PointerEvent #495

Uh oh!

Conversation

sahirv commented Jan 11, 2024 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickhlauke commented Jan 17, 2024

Uh oh!

sahirv commented Jan 17, 2024

Uh oh!

Uh oh!

Uh oh!

sahirv commented Mar 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sahirv commented Jun 10, 2024

Uh oh!

sahirv commented Jun 17, 2024

Uh oh!

patrickhlauke commented Jul 4, 2024

Uh oh!

smaug---- commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sahirv commented Jul 18, 2024

Uh oh!

sahirv commented Jul 29, 2024

Uh oh!

patrickhlauke commented Aug 14, 2024

Uh oh!

Uh oh!

sahirv commented Jan 11, 2024 •

edited by pr-preview bot

Loading

smaug---- commented Jul 17, 2024 •

edited

Loading