You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "Process Pending Pointer Capture" section, likewise the
pointerout/leave that is mentioned in this section in some
cases we need to send pointerover/enter when the capture
is lost and pointer is on another node that is not the
capturing node.
In "Process Pending Pointer Capture" section, likewise the
pointerout/leave that is mentioned in this section in some
cases we need to send pointerover/enter when the capture
is lost and pointer is on another node that is not the
capturing node.
Thanks Navid, this looks reasonable to me! But this space is pretty complicated and I'm not an expert, so let's see if someone from Edge can also review the precise wording before we land it (eg. @teddink?).
Presumably this was also a test hole in the tests, right? Can you submit an update for that as well?
I haven't looked at the tests for the pointer capturing coverage yet. I will keep this in mind when I'm reviewing and testing those on Chrome to add anything that's missing.
One quick suggestion while we are into it: it seems to me that the section "Process Pending Pointer Capture" should really belong to the "Pointer Capture" section, perhaps between Sec10.2 & Sec10.3, because it is impossible to follow this section w/o skimming through 10.1 & 10.2 first. Only thing we need in the current section (Sec5.2.1) is a reference to the fact that we need to process pending capture before firing a "non-capture" PointerEvent.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "Process Pending Pointer Capture" section, likewise the
pointerout/leave that is mentioned in this section in some
cases we need to send pointerover/enter when the capture
is lost and pointer is on another node that is not the
capturing node.