| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 09 Oct 2025 00:09:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.683097,conversation_content-fragment;desc="conversation_content fragment";dur=2254.970317,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=383.633557,nginx;desc="NGINX";dur=1.1829,glb;desc="GLB";dur=136.273789
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pWu%2BJkAKy1X7NoWxsIrHtUNBiov8u7JJo175tYyIDizR03%2BXkxoJtVIMyrQ8LyEXXYgHwhzDSrXhJuICy1AzYMUF%2FrrifHqOczBk29JNGDyoCQyWjkZnUWgKfihMxwFplqWkye19P4vsFyvIyVdPOM1KsITP2HURe28B6tKuYcdwQ0sqoj3Q5GOVbEARUraKzFyQFUuzCnS9DXa3wCgBelhfzFKj4OGlDGx%2Bkw9w6v3Q4h2jLwfRBMl1nb948i7qX8w4O%2FKjkny1KNyEjFDxJA%3D%3D--KGSCjflYJiVzulwn--cdSHNbU68w1nbBhEBU5r5Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1124464408.1759968558; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 00:09:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 00:09:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 86B0:35308D:1B9685:26D99B:68E6FD2E
Define concepts for converting and validating `.data` by stephenmcgruer · Pull Request #977 · w3c/payment-request · GitHub
Define concepts for converting and validating
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
November 19, 2021 12:46
marcoscaceres
changed the title
[Editorial] Define a concept for converting and validating .data
Editorial: Define a concept for converting and validating .data
Jan 19, 2022
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
July 6, 2022 13:16
stephenmcgruer
changed the title
Editorial: Define a concept for converting and validating .data
Define concepts for converting and validating Jul 6, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
Define concepts for converting and validating .data
#977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
7a6cfe4 to
c3d0335
Compare
|
@marcoscaceres - fyi this is my suggestion for adding a |
marcoscaceres
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation should be separate from conversion...
marcoscaceres
changed the title
|
cc @ianbjacobs as landing this blocks w3c/secure-payment-confirmation#194 The build is currently failing because the upstream of this PR (#976) is behind HEAD and needs updated to include 34c206f |
stephenmcgruer
added a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Jun 30, 2022
marcoscaceres
previously requested changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting this makes a couple of normative changes... in particular, it no longer exclusively throws a TypeError during the processing steps.
This makes it easier for other specifications to clearly indicate their defined steps to convert and validate the data member.
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
2b4692a to
a389afa
Compare
stephenmcgruer
changed the title
.data
Good catch - thanks for noticing this! I've updated the PR description and title (along with addressing your other comments) to reflect that new errors may be thrown. |
marcoscaceres
approved these changes
Jul 7, 2022
stephenmcgruer
added a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Jul 7, 2022
marcoscaceres
added a commit
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR introduces two new definitions (
dfn) for both the IDL type thatPaymentMethodData/datashould be converted into, and for the validationsteps that a payment method will perform on it. This allows payment method
specs to define these in a way that is cross-linkable to the PaymentRequest
specification.
This change is mostly editorial, except that it allows for arbitrary error types
to be thrown during validation (previously only
TypeErrorwould be thrown).Preview | Diff