CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 137
Rename PayerErrorFields
to PayerErrors
#789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling. So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec? Secondly, you need to check that Lastly, we need to get implementation commitment from various browsers. @aestes, @romandev or @rsolomakhin, minor bike shedding change? You all ok with this change? |
PayerErrorFields
to PayerErrors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename looks good.
Marked as non substantive for IPR from ash-nazg. |
Firefox tracking bug https://bugzilla.mozilla.org/show_bug.cgi?id=1495335 |
Chromium tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=890660 |
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
Hi , thanks for the review , i will make sure from next time , its done totally by mistake.
Hi @marcoscaceres , I checked the
Yes we are lucky its not documented https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/PayerErrorFields, do we need to create another issue for the same? 😄 |
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
@akansha2608, no, we generally just do it as part of this issue and then check the box at the top when it's done. I'm seeing at least one mention of Could you kindly please update it? |
Hi @marcoscaceres i updated this. Can you guide me through first about first about documentation please :) How to do that? |
Will follow up on Slack. |
Merging this so it's easier to do the docs |
Related spec change: w3c/payment-request#789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae Reviewed-on: https://chromium-review.googlesource.com/1253942 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595795}
WebKit tracking bug: https://bugs.webkit.org/show_bug.cgi?id=191213 |
closes #782
The following tasks have been completed:
Modified Web platform testsIDL is automatically updated.Implementation commitment:
Optional, Impact on Payment Handler spec?
Preview | Diff