| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 09 Oct 2025 00:08:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=330.027552,conversation_content-fragment;desc="conversation_content fragment";dur=1334.943406,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=363.648689,nginx;desc="NGINX";dur=0.833933,glb;desc="GLB";dur=138.306005
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=WYmeigAAJIuiBxC%2BHzynxBIlr89KEQF59E255NDzeohkXDSw%2B8YfDLLlfKskt%2BQ0RRyWIlwK2JKBgw%2BJBJJJRlq0mvXn7EdwZXI8zkPIdoWW09c%2BpWGls38m8Ob71tukXEwMQzIfQgQm%2B9LlBRZ8AHCDQ9tuZWxEwbARoWyjHhKmLa9OB8ZisJAYnjeyGINuD9A4mHbtD1CsuGh8%2Fx23n%2B%2BXBOGF%2F%2FcOeMaeOn434UviJbGQj4xjUa63VqAc98T7PpBXDtsr%2F294eUbthmsE4Q%3D%3D--IPDIIsqG%2BHTjy2ku--MzX0Shtf1cPQXjRDxcObgA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.856246303.1759968512; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 00:08:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 00:08:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 870E:2AA7F:1AFF0A:26343F:68E6FD00
Add MerchantValidationEvent.prototype.methodName by marcoscaceres · Pull Request #776 · w3c/payment-request · GitHub
marcoscaceres
force-pushed
the
mve-methodName
branch
from
September 12, 2018 05:42
marcoscaceres
force-pushed
the
mve-methodName
branch
from
September 12, 2018 05:45
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
Add MerchantValidationEvent.prototype.methodName #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
mve-methodName
branch
from
1e39f95 to
a07e0cd
Compare
marcoscaceres
force-pushed
the
mve-methodName
branch
from
a07e0cd to
2033962
Compare
rsolomakhin
approved these changes
Sep 12, 2018
domenic
approved these changes
Sep 12, 2018
| empty string, run the steps to <a data-cite= | ||
| "payment-method-id#dfn-validate-a-payment-method-identifier">validate | ||
| a payment method identifier</a> with | ||
| <var>eventInitDict</var>["<a>methodName</a>"]. If it returns false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always unsure how much validation we should be doing in event constructors, i.e. should they be dumb property bags that hold whatever you pass in, or should they enforce domain logic constraints. But this is good for now, and consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thought about the same. Consistency allows us to treat both implementers and user-land code as potentially invalid, which I think is a good thing.
aestes
approved these changes
Sep 12, 2018
|
@aestes, @rsolomakhin, thanks also for the speedy review! Thanks @aestes for already adding the link to Safari! @rsolomakhin, do you have a link too a Chrome bug? |
|
@marcoscaceres I filed a bug instead of Rouslan. https://crbug.com/883605 |
|
Wrote some initial MDN docs for MerchantValidationEvent: @aestes, do have development docs folks on the Safari side that can fill out the rest? Otherwise, we can get folks over on the Mozilla/MDN side to do it. However, want to make sure what is there is right, as it's (right now) very Apple Pay specific. |
|
Ah, @romandev, you are the best. Thanks for filing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
closes #775
The following tasks have been completed:
Implementation commitment:
Optional, Impact on Payment Handler spec?
Preview | Diff