You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.
I haven't checked the code in detail, but i read #236 and this seems like a useful feature, so long as the user is still presented with the buttons allowing them to choose an alternative language. If that's not the case, i won't approve this change. @kojiishi can you confirm?
so long as the user is still presented with the buttons allowing them to choose an alternative language. If that's not the case, i won't approve this change. @kojiishi can you confirm?
But the latest ED presumably doesn't include these changes(?) since they haven't been merged yet.
To speed things up i'll mark this as accepted on the assumption that the buttons will still be there after merging. I took another look at the code, and it doesn't seem to affect the buttons.
This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.
Thanks for the approval. I rebased to the ToT and confirmed it's still working. I was actually a bit scary because the original patch was 3 years ago ;-)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.
Fixes #236.