CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4
Update orthographic syllable related definitions #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Addresses comments in #76
✅ Deploy Preview for i18n-glossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
index.html
Outdated
|
||
<div class="letter_anchor" id="o">O</div> | ||
<p><dfn class="lint-ignore export">Othographic syllable</dfn> A [=typographic character unit=] that includes more than one [=grapheme cluster=]. These are most commonly found in Brahmi-derived scripts, such as Devanagari, or Balinese, when forming conjuncts or stacks. This term is used but not defined in the Unicode Standard: it is defined here for use by W3C documents, such as layout requirements.</p> | ||
<p><dfn class="lint-ignore export">Othographic syllable</dfn> A [=typographic character unit=] that includes one or more [=grapheme clusters=]. These are most commonly found in Brahmi-derived scripts, such as Devanagari, or Balinese, when forming conjuncts or stacks. They commonly demarcate sequences of characters that are different from phonetic syllables, and they may even span word boundaries. See also the <a href="https://unicode.org/glossary/#orthographic_syllable" target="_blank">definition</a> in the Unicode Standard.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider parenthesizing "such as Devanagari" instead of using a wayward comma:
... Brahmi-derived scripts (such as Devanagari) or Balinese, when...
Note: It is a lot easier to work with text in github when lines are manually broken. In order to use a suggestion, here I would have to retype the entire paragraph when mostly what I want is a specific couple of lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
index.html
Outdated
|
||
<div class="letter_anchor" id="o">O</div> | ||
<p><dfn class="lint-ignore export">Othographic syllable</dfn> A [=typographic character unit=] that includes more than one [=grapheme cluster=]. These are most commonly found in Brahmi-derived scripts, such as Devanagari, or Balinese, when forming conjuncts or stacks. This term is used but not defined in the Unicode Standard: it is defined here for use by W3C documents, such as layout requirements.</p> | ||
<p><dfn class="lint-ignore export">Othographic syllable</dfn> A [=typographic character unit=] that includes one or more [=grapheme clusters=]. These are most commonly found in Brahmi-derived scripts, such as Devanagari, or Balinese, when forming conjuncts or stacks. They commonly demarcate sequences of characters that are different from phonetic syllables, and they may even span word boundaries. See also the <a href="https://unicode.org/glossary/#orthographic_syllable" target="_blank">definition</a> in the Unicode Standard.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you've got <a...
instead of <a...
, so it appears as markup in https://pr-preview.s3.amazonaws.com/w3c/i18n-glossary/pull/77.html#dfn-othographic-syllable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's wierd. Thanks for noticing. Fixed.
Merging before this becomes stale. If there are other problems, they can be raised in new issues. |
Addresses comments in #76
Preview | Diff