| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 05 Oct 2025 23:11:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=331.080423,conversation_content-fragment;desc="conversation_content fragment";dur=529.370804,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=262.305213,nginx;desc="NGINX";dur=0.912053,glb;desc="GLB";dur=138.318018
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jrqGI0l6khQcbVYZ8sgJkHEGYEFY5%2BAUoKlByXUPYpNHWOcFK561mwFCp5gr%2BwWeyjCdTevHiHkTJYxj1UmT%2BwzH7w8GarwDnXgYgpw2CQTbim%2BGmBB5OdbGYW6UrB%2BFPjRs42l32MSgSF%2BCsU4rFkixFvXoRnPbJWyvgHiq3xPnSR%2Bog0IEmuxBWyAruvbGjJ5GD4Y2CoEeRQosjSGqkZQr%2BF2zPWO12LVZD8ywGQm8NllKai0oR%2FWAP2ZLatOP1NJ0A2bVMIcDyLVIQ9rcnw%3D%3D--%2BCgyt82wqHWAT0Xp--ZF7WxT48tEWbK%2BkRQsocEg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1462401733.1759705918; Path=/; Domain=github.com; Expires=Mon, 05 Oct 2026 23:11:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 05 Oct 2026 23:11:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B2B4:38A8F3:1453882:1B0FFE1:68E2FB3E
disallow aria-hidden on body element by scottaohara · Pull Request #447 · w3c/html-aria · GitHub
scottaohara
added
Allowed aria-* attributes
needs changelog entry
once 2 implementations land, we can merge and note it in our changelog.
labels
Mar 3, 2023
scottaohara
added
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
and removed
needs changelog entry
once 2 implementations land, we can merge and note it in our changelog.
labels
Mar 6, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 49
disallow aria-hidden on body element #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to w3c/aria#1254 closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
scottaohara
added
Allowed aria-* attributes
needs changelog entry
as `aria-hidden=false` doesn't seem to cause any problems, even per the note in ARIA to use with caution: >At the time of this writing, aria-hidden="false" is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach. let's limit this rule to just `aria-hidden=true`
This was referenced Mar 3, 2023
scottaohara
added
Meets 2 implementations req
patrickhlauke
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks @scottaohara
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Allowed aria-* attributes
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
related to w3c/aria#1254
closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
labels: needs implementation commitment, needs changelog entry
Preview | Diff