You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates many elements to match the new roles introduced in ARIA 1.2 (working through issue #229), and which are in core aam. The updated elements are as follows:
blockquote
caption
code
del
em
ins
meter
paragraph
strong
sub
sup
time
NOTE: I have not presently updated the mapping for figcaption to the caption role. At various times, people have expressed their unhappiness with the figcaptoin element's current behavior, and the redundancy / verbosity impacts it has as the accessible name for figure. @jnurthen I would like to add this as a future agenda item to the ARIA wg call - specifically the group's feelings on changing figcaption to provide a description, rather than name βΒ or some other alternative.
Additionally, this PR fixes the mappings for body, htmland hgroup
Further, some updates to remove the mention of "?" cells from the 3.4 introduction, and that UAs must not expose aria-roledescription on generic elements.
Lastly, this PR updates the following elements which map to generic (or will map to generic under certain conditions). This, along with the updates to body and hgroup starts the work on #346.
`html` should have mapped to `document` - this is now corrected and the table now indicates to refer to the WAI-ARIA mapping for the document role.
`body` no longer maps to `document` - which matches reality. `body` now maps to `role=generic`. further updates may be needed here for instances where authors incorrectly name a generic / provide the body with elements important to accessibility - e.g., `contenteditable`.
closes#330
* remove bullet about β?β cells. these have all been removed.
* update list item about `aria-roledescription` and mention that UAs must not expose the attribute if used on an implicit `generic` element.
this PR updates the following elements to point to their implicit ARIA roles defined in core aam
* caption
* code
* del
* em
* ins
* meter
* paragraph
* strong
* sub
* sup
* time
starts on issue #346, indicate some of the elements that will map to, or under certain conditions map to `generic`
* autonomous custom elements
* div
* form without accessible name
* form associated custom elements
* section without accessible name
per my mention about speaking to the WG regarding figcaption, there was consensus in the working group to not have figcaption contribute to the accessible name of a figure. instead, it was suggested that an aria-details association between the figure and the figcaption seemed to make the most sense, since a figcaption can contain structured and interactive content that would be less meaningful as a flattened text string (name or description).
all that said, this PR will not be updated to map figcaption to the caption role
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates many elements to match the new roles introduced in ARIA 1.2 (working through issue #229), and which are in core aam. The updated elements are as follows:
NOTE: I have not presently updated the mapping for
figcaption
to thecaption
role. At various times, people have expressed their unhappiness with thefigcaptoin
element's current behavior, and the redundancy / verbosity impacts it has as the accessible name forfigure
. @jnurthen I would like to add this as a future agenda item to the ARIA wg call - specifically the group's feelings on changingfigcaption
to provide a description, rather than name βΒ or some other alternative.Additionally, this PR fixes the mappings for
body
,html
andhgroup
generic
(related to update elements that now map to role=genericΒ #346 and Mappings for body and html don't seem to match realityΒ #330) )document
(closes Mappings for body and html don't seem to match realityΒ #330)generic
(closes hgroup mappings do not seem correctΒ #331)Further, some updates to remove the mention of "?" cells from the 3.4 introduction, and that UAs must not expose
aria-roledescription
on generic elements.Lastly, this PR updates the following elements which map to
generic
(or will map togeneric
under certain conditions). This, along with the updates tobody
andhgroup
starts the work on #346.Preview | Diff
Preview | Diff