You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1 to merging as is because I don't know what the purpose of this parameter is and because it seems like it would tend to produce a set of keys whilst losing their authorized purpose (which could be dangerous). It is also "key" specific, not allowing for other types (i.e., why not "type="?).
I don't understand the use case here... why can't you just write a function to go through the DID Document and fetch all of these keys?
I'm trying to understand where we'd put a value like this -- did:example:1234;key-type=Ed25519VerificationKey2018 ... like, we'd put it in a database table because we'd want to get the set of all Ed25519VerificationKey2018s, but I'm struggling to figure out why we'd put this value in a database table vs. just write a function to extract what we want from the DID Document?
The reason will be displayed to describe this comment to others. Learn more.
I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.
The reason will be displayed to describe this comment to others. Learn more.
I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.
@msporny@brentzundel@burnburn can we get labels on all the open PRs related to changes that have matrix parameters in them, and mark them as "pending-close"... we have a lot of PRs open... PRs should not remain open unless they are being worked on / going to be merged within a week or 2.... we are loosing the ability to focus reviews on things that need reviews...
Marked pending close after the resolution 1 on the 4/7/2020 call.
I agree this should be closed, but the reason for closing is that there has been consensus that there is no need for having key-type as a DID parameter in the DID URL. The resolution on the 2020-04-07 call was about the syntax of DID parameters, which is independent of the question which DID parameters we want.
Let's take this up on the next special topic call since we're still discussing the general area of DID Parameters.
Sounds good, I'll hold off on taking any other action until I see confirmation from an editor or chair and will instead prompt others to take action if I see it becomes stale.
pending closeIssue will be closed shortly if no objections
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-creating PR from CCG repo: w3c-ccg/did-spec#193. Please consider earlier discussions there.
Preview | Diff