You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made the changes I've mentioned in #9719. That is, SVGs are used instead of PNGs, the file names have been aligned with the rest of the assets and the alternative text has been removed because it's unnecessary because the description of the images is right above them.
I would leave the height as 1em so it scales with text. Otherwise looks good.
I've changed them to be 1em high, though note that this is counter-productive when users have chosen a different font size than 16px because the images then get stretched vertically which let's the text "transparent" appear stretched as well.
I am wondering why the stripes() examples should be svgs, the other images are pngs in the draft.
I only did that for the stripes() example images because they were added lately. The others may also benefit from being replaced by SVGs but note that not all of them can actually be represented as SVGs. Only the ones that show features current browsers actually support should be replaced.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made the changes I've mentioned in #9719. That is, SVGs are used instead of PNGs, the file names have been aligned with the rest of the assets and the alternative text has been removed because it's unnecessary because the description of the images is right above them.
Sebastian