You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c03b2ea changed <color-stop> = <color> <length-percentage>? to <linear-color-stop> = <color> && <length-percentage>?
I believe the && was a mistake, since <length-percentage> <color> doesn't seem to be valid?
Note: This also affects [css-images-4], which uses the same definition.
Also for what it is worth, Chrome and FF do not parse position(s) before the color as valid, and if it should be allowed, it may be odd to be able to specify both positions before or after the color, but not a color between them.
Yeah, reviewing the diff I'm almost certain it was just a mistake while writing it - it looked reasonable to use an && in the grammar while I was rewriting. I still think it's probably reasonable to do so, but nobody's followed that in forever and it's not very important, so reverting to the old spec text which matches impls makes sense.
cdoublev
added a commit
to cdoublev/csswg-drafts
that referenced
this pull request
Aug 3, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c03b2ea changed
<color-stop> = <color> <length-percentage>?
to<linear-color-stop> = <color> && <length-percentage>?
I believe the
&&
was a mistake, since<length-percentage> <color>
doesn't seem to be valid?Note: This also affects [css-images-4], which uses the same definition.