You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was no definition of text-shadow composition. To match the behavior of other list-like properties such as transform lists (https://drafts.csswg.org/css-transforms-2/#combining-transform-lists) and box-shadow (#4374), this PR specs addition as list concatenation and accumulation as component-wise addition.
If there's already a definition for addition and accumulation of shadows, why aren't we reusing it? I don't think text-shadow should get its own one-off definition here.
This may be overly pedantic. I'm not very familiar with box-shadow and text-shadow, so it's unclear to me whether they differ enough to have different definitions for addition/accumulation. I would have thought if they were alike enough then we would have extracted a common value for them out and could define things like computed-style and animation on that?
But if a css-text-decor-3 would rather we just point at https://drafts.csswg.org/web-animations-1/#animating-shadow-lists, I'm happy to do that. I feel it is important to do something here, since Chrome and Firefox ended up with different behaviors due to this not being defined in the specs.
Committed cross-references between text-shadow and Web Animations' shadow lists. Closing out this PR. @stephenmcgruer Let me know if there's any problem (preferably by filing a new issue; I'm unlikely to notice replies here, tbh).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was no definition of text-shadow composition. To match the behavior of other list-like properties such as transform lists (https://drafts.csswg.org/css-transforms-2/#combining-transform-lists) and box-shadow (#4374), this PR specs addition as list concatenation and accumulation as component-wise addition.
See #4330