CARVIEW |
Select Language
HTTP/2 302
date: Mon, 06 Oct 2025 14:01:01 GMT
content-length: 0
location: https://github.com/w3c/csswg-drafts/pull/6806
server-timing: nginx;desc="NGINX";dur=0.791771,glb;desc="GLB";dur=146.744872
x-voltron-version: 266d7a9
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=9pU7GuVqzpuYb168niNrYITBvyaERG1%2BQp7hKHVXA1Qdxsielyq%2B6at5wgB4I7YiiKFMf3LgXDnucbP5L8V%2B5PVhS3H9s4Bm11Yevc8xtjb1mhun72g8lYiYm4jVf8aIf1UNp7sApy4pbqshoVwe7u3z44T31uEWlatf8NCEi5bH4oUgQvIY1vosO1tNd4eJosuOmeI1Hy%2F%2FSooAgh920bzFzveBvzbMi6DpBu1It6QMtB2SO%2FFSYduU01lk2QI5lfEnz2xJFrCn8XE70DKzVg%3D%3D--F1mbo3ExvYgFzh5r--h2QaPxcqQbgFKxa2tTT9Tw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.283028186.1759759261; Path=/; Domain=github.com; Expires=Tue, 06 Oct 2026 14:01:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 06 Oct 2026 14:01:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C6CA:3EC2A4:24FD4BD:2E4FFF5:68E3CB9D
HTTP/2 200
date: Mon, 06 Oct 2025 14:01:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=341.213499,conversation_content-fragment;desc="conversation_content fragment";dur=742.534212,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=903.222597,nginx;desc="NGINX";dur=1.494071,glb;desc="GLB";dur=143.607185
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C6CA:3EC2A4:24FD551:2E50099:68E3CB9D
[mediaqueries-4] Lift parens to <media-in-parens> by andruud · Pull Request #6806 · w3c/csswg-drafts · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 746
[mediaqueries-4] Lift parens to <media-in-parens> #6806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For container queries (css-contain-3), it would be convenient to be able to reference paren-less <media-feature>, since that grammar wants to wrap the value in a function rather than plain parentheses.
Yeah, I like that organization a little better too, keeping all the parens up in the same production. |
mirisuzanne
reviewed
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Nov 25, 2021
In order to make it easier to define the grammar of container queries, there was a change in the spec regarding where parens enclosing a <media-feature> are handled. Previously, the parens were part of <media-feature> itself, but as of [1] they were lifted to the <media-in-parens> production. This CL represents the corresponding change in our parser, as a preparation for implementing the container queries syntax. MediaQueryFeatureExpNode now represents the "bare" <media-feature>, without any parens in its serialization. The parens are added explicitly as a MediaQueryNestedExpNode wrapped around the MediaQueryFeatureExpNode. [1] w3c/csswg-drafts#6806 Bug: 1214810 Change-Id: I69c0082fac02d18623beed06228be57a91e7c282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301699 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#945339}
cdoublev
added a commit
to cdoublev/csswg-drafts
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
For container queries (css-contain-3), it would be convenient to
be able to reference paren-less
<media-feature>
, since that grammarwants to wrap the value in a function rather than plain parentheses.
As far as I can tell,
<media-feature>
is only used by<media-in-parens>
,so this should be safe.