| CARVIEW |
Select Language
HTTP/2 302
date: Fri, 18 Jul 2025 20:09:00 GMT
content-length: 0
location: https://github.com/w3c/csswg-drafts/pull/2597
server-timing: nginx;desc="NGINX";dur=0.879234,glb;desc="GLB";dur=95.373209
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=FDNN3EB%2B3uG%2Fu4aAavrsbWEyLV1GWcvQdKvvpgnYm2BFFhBKXHkL50TDGtLlth%2FQr2XdRoZqAqG0jhp15vOjCypxd9rFfhlo6NTMeMBEkCo9oQ5MOh0iGW9R2ooZIOgEpCAgFIv4Y7fpSngzdLEolKY4RMyxuljMXAzrwAyMlP5A0r9MCuGtEx8y3Dy039L%2BvWgiWhToqkX5qnOPF4EPMxPVebkn%2FFrXrh%2Bh1CDJceswXxGYscxHt46fPIOheaaH1ayIWwF1qviq6eZihf6w%2Bw%3D%3D--i0%2F1gBLMuz8Oez0u--qHYaJu4zeeNus3RNAh%2FrLg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1594645237.1752869340; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 20:09:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 20:09:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DC6C:2DDAD2:13985E:191954:687AA9DC
HTTP/2 200
date: Fri, 18 Jul 2025 20:09:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=295.797722,conversation_content-fragment;desc="conversation_content fragment";dur=942.884553,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=286.326649,nginx;desc="NGINX";dur=0.71314,glb;desc="GLB";dur=95.684126
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DC6C:2DDAD2:139894:19199A:687AA9DC
Establishing a new formatting context by frivoal · Pull Request #2597 · w3c/csswg-drafts · GitHub
frivoal
added
css-align-3
Current Work
css-contain-1
css-display-3
Current Work
css-flexbox-1
Current Work
css-grid-1
css-multicol-1
Current Work
css-rhythm-1
Needs Feedback/Review
labels
Apr 20, 2018
tabatkins
removed
css-align-3
Current Work
css-contain-1
css-flexbox-1
Current Work
css-grid-1
css-multicol-1
Current Work
css-rhythm-1
labels
May 7, 2018
frivoal
added
Commenter Satisfied
Commenter has indicated satisfaction with the resolution / edits.
Closed as Duplicate
and removed
Needs Feedback/Review
labels
May 8, 2018
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 729
Establishing a new formatting context #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoal
added
css-align-3
|
I think https://drafts.csswg.org/css-display-3/#transformations should say that blockifying causes the element to establish a new formatting context. Then there would be no need to explicitly say that e.g. flex items are both blockified and establish a new formatting context, the former would imply the later. Edit: filed #2598 |
|
@Loirooriol Could you file that as a separate issue? This is kind of related, but it seems to me to be an independent decision to make, so a separate issue seems better (also, this issue that this pull request is based on is already way too long). |
Loirooriol
reviewed
Apr 30, 2018
css-display-3/Overview.bs
Outdated
| without further precision as to the type of formatting context or how to do so. | ||
| This operation is not applicable to | ||
| non-atomic inline-level boxes | ||
| nor to boxes with a layout-internal display-type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct terminology seems "display type" without hyphen. And I reiterate that display types should probably belong only to elements (and pseudo-elements), not boxes, but this problem is all over the spec.
… which (Follow up on 1457)
These specs used the "establish a [new] formatting context" terminology. Link to the exported definition now that there is one. This change is editorial. This is a follow up on w3c#1457
Grid and Flexbox used to need a sentence to say what kind of formatting context grid/flex items would establish. Since that is now part of the definition of "establishing a [new] formatting context", just link to it. This change is editorial.
instead of using correct-but-unique phrasing to do the same thing. This change is editorial.
tabatkins
removed
css-align-3
|
We had to do some substantial rewriting on this, so closing this PR. (We'll link to it when we commit our results.) |
frivoal
added
Commenter Satisfied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closed as Duplicate
Commenter Satisfied
Commenter has indicated satisfaction with the resolution / edits.
css-display-3
Current Work
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
As discussed in the resolution of #1457 we should add to css-display a linkable definition for establishing a (new) formatting context without explicitely saying which kind, and still have the right thing happen unambiguously when possible, while being explicit that it is a spec bug to invoke this definition in the cases where it's not meaningful/possible.
This PR attempts to add this definition, and to update all the specs that should use it to do so.
I am not particularly attached to the phrasing I am proposing here. I believe it to be correct, but certainly welcome more elegant ways of saying the same thing if anyone has suggestions.
Review from @fantasai or @tabatkins (but particularly @fantasai) appreciated.
Changes in css-contain css-multicol css-align and css-rhythm should be particularly safe, since this is just adding a link without rephrasing anything.
Changes to the other specs are meant to be no-ops that merely unify the way we talk about this, without any normative effect.