| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 17 Jul 2025 23:34:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=282.394469,conversation_content-fragment;desc="conversation_content fragment";dur=713.541876,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=195.052555,nginx;desc="NGINX";dur=1.07175,glb;desc="GLB";dur=95.503862
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3nVE6VCIXfs0P%2FbkPSzYlUxbUUGEO2pxGmMaH76ImV5ZqkvwOaZ35%2B0mXUt6uwCwRGhj6EfFQ1CXmdAwCKU7rgMCvYDjNgfnQwJDSZuqEVFjhWyqtk%2BzCP5%2B8I7I%2FS9UUZMBxetfDxq%2BvLiPsjZXzKK0K348W9iASaxbFEtKctsSOgmQmxSbHrtJT7jqbuxfvH2%2BXqE2QqNdj%2B9qpmsA1KxqO3IIaJHf7i8a7Gr69pVUx%2FM9RRKQS5O4%2BTXuxm8QKPEWzYzJ2AT3AOnXYZjngw%3D%3D--T07Dvq8fUePq8rLg--1xwGmCEGZ5LR9YCMl3Oh5w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1519383428.1752795241; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 23:34:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 23:34:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E43A:32A5A3:5AC95E:6FD0BE:68798869
Add type checking to `CSSNumericValue.parse` by xiaochengh · Pull Request #1065 · w3c/css-houdini-drafts · GitHub
Add type checking to
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 142
Add type checking to CSSNumericValue.parse
#1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tabatkins PTAL |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 28, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 31, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 31, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 31, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351}
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2022
…SSNumericValue::parse(), a=testonly Automatic update from web-platform-tests Add <dimension-token> type-checking to CSSNumericValue::parse() This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351} -- wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92 wpt-pr: 32603
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 1, 2022
…SSNumericValue::parse(), a=testonly Automatic update from web-platform-tests Add <dimension-token> type-checking to CSSNumericValue::parse() This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351} -- wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92 wpt-pr: 32603
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…SSNumericValue::parse(), a=testonly Automatic update from web-platform-tests Add <dimension-token> type-checking to CSSNumericValue::parse() This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351} -- wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92 wpt-pr: 32603
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…SSNumericValue::parse(), a=testonly Automatic update from web-platform-tests Add <dimension-token> type-checking to CSSNumericValue::parse() This patch implements a recent spec bug fix: w3c/css-houdini-drafts#1065 Fixed: 1291603 Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#965351} -- wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92 wpt-pr: 32603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #1064