You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to the text except for “will embed” -> “embeds” (because we are in fact actively doing this, though of course we can always do better) and fixing capitalization of “web” to “Web”.
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable primarily editorial edit. The reshuffling and "will embed" to "embeds" is fine by me (as is the curly apostrophe :).
I restored the removal of one trailing blankspace, as I prefer that as a semantic indicator of soft-wrapping, and added a trailing blankspace to the edit where you broke one line into two (which itself is also fine).
@tantek I can restore those blank spaces if you think it's important, but I will note that trailing spaces are most often considered to be an error and many editors will remove them automatically. So my suggestion would be to align on the convention of no trailing spaces: because these characters are invisible and the prevailing convention is to remove them, you are most likely to get consistency this way.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to the text except for “will embed” -> “embeds” (because we are in fact actively doing this, though of course we can always do better) and fixing capitalization of “web” to “Web”.
Preview | Diff