You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cwilso I'm not sure I understand your comment, but I think these are two different (certainly related) things:
technical soundness is something we ensure through the deep review that happens through our WG discussions, and through our implementation experience requirements -- ensuring out specs are thorough, detailed, well-thought out
architectural integrity is about ensuring the whole system hangs together, and we do it mainly through TAG review and that kind of thing
We do both, and both are valuable, but they are distinct; so that's why I kept them distinct in the PR.
The reason will be displayed to describe this comment to others. Learn more.
Upon deeper reflection and a bit of research of prior wording of these things at W3C (multiple sources), I have edited the PR to a single line to encapsulate both in a shorter phrase that has established use at W3C.
I do agree with the use-cases / motivations in both issues @fantasai has mentioned and believe this edit now reinforces and resolves both.
@tantek I don't think folding to "technical architecture" encompasses both, because you can have good architecture and sloppy details. As I outlined in #173 (comment) we really do explicitly review for both.
[reverted to the original commit; please don't edit someone else's PR, it's very weird to have one's proposal unilaterally replaced with someone else's proposal]
[reverted to the original commit; please don't edit someone else's PR, it's very weird to have one's proposal unilaterally replaced with someone else's proposal]
Sorry this was me being clumsy with GitHub UI and attempting to suggest edits to a PR and clicking the wrong series of buttons / not understanding what I was doing. :/
The reason will be displayed to describe this comment to others. Learn more.
Suggest placing these additions at end of that list, both per cited examples, and perhaps more importantly following some of the priority of constituencies:
users (a11y, i18n, s12y, privacy, security)
over implementers (technical soundness)
over theoretical purity (architectural integrity).
tantek
changed the title
[Vision] Add technical soundness and architectural integrity to Thorough Review
Add technical soundness and architectural integrity to Thorough Review
Sep 30, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #170 #141
Preview | Diff