CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 01:07:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=315.287684,conversation_content-fragment;desc="conversation_content fragment";dur=342.846234,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=200.384501,nginx;desc="NGINX";dur=1.259525,glb;desc="GLB";dur=100.812526
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=4sZiV7CNaA7IOEfZlOGVBPCW%2BPR0IpQ%2BZacv65CrErVRSk9gHbMAyUOgiqdkHlgtLSao4Llk5YrA6h8p90rrK7ZlO9vJFjoKGTzaG9xvUAOuKwFCwVbUmg18OKiIu598sbYOE8V%2FbeHD1ChnZFR477bsBg1KI7TYVffXoYopoZORg38KUizNX3JecGINzfu8XPIylSAL%2F1ztFRAqnabHFKwlMD4I3H6KsbffH6UwnA6Vf%2BNTFc0hzbBXPJnSGZCAlKgjR6IEjXnqwwTCwNg4RA%3D%3D--K9MJVW7TSdXu9A5f--OrFK4H8zaZ8vIbj5sK%2F1UQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1553482059.1753578478; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 01:07:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 01:07:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A66A:3240E6:9BB13A:CDF3E3:68857BEE
Tagged unions generated for Jackson @JsonTypeInfo with EXISTING_PROPERTY by vojtechhabarta · Pull Request #582 · vojtechhabarta/typescript-generator · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 247
Tagged unions generated for Jackson @JsonTypeInfo with EXISTING_PROPERTY #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This change is expansion of tagged (discriminated) union feature introduced in #81. It adds support for Jackson polymorphic types discriminated by
EXISTING_PROPERTY
.Already supported is
PROPERTY
variant of Jackson polymorphic types but there are issues with it. In this case Jackson adds discriminant property when serializing sub-class and uses this additional property to deserialize JSON object to correct Java sub-class. But this mechanism doesn't work in cases where type information is not available to Jackson. For example when passingList
of such objects directly to Jackson likenew ObjectMapper().writeValueAsString(List.of(new SomeSubClass()))
then specifiedPROPERTY
is not included. Another case where this mechanism doesn't work is Spring REST controller where return type of some method contains such class wrapped in generic class, for exampleOptional<T>
, like this@GetMapping Optional<SomeRootClass> test() { return Optional.of(new SomeSubClass()); }
.Since using
PROPERTY
causes described issue it is now supported to use variant withEXISTING_PROPERTY
. In this variant Jackson uses value of regular (existing) property when serializing those objects but it uses annotations when deserializing them. So it can be inconsistent. However it is possible to mitigate this disadvantage and get reasonable level of confidence. For example we can havefinal
field filled in mandatory constructor call and use constants like this:Or we could reuse values from annotations for example like this:
Both examples have, of course, their pros and cons.