fix(Slider): thumb has incorrect tag by default (#1734)

zernonia · web-flow · commit f8ebc9ecd919 · 2025-03-21T18:29:54.000+08:00
diff --git a/docs/content/meta/SliderThumb.md b/docs/content/meta/SliderThumb.md
@@ -6,7 +6,7 @@
     'description': '<p>The element or component this component should render as. Can be overwritten by <code>asChild</code>.</p>\n',
     'type': 'AsTag | Component',
     'required': false,
-    'default': '\'div\''
+    'default': '\'span\''
   },
   {
     'name': 'asChild',
diff --git a/packages/core/src/Slider/SliderThumb.vue b/packages/core/src/Slider/SliderThumb.vue
@@ -10,7 +10,9 @@ import SliderThumbImpl from './SliderThumbImpl.vue'
 import { useCollection } from '@/Collection'
 import { computed } from 'vue'
 
-const props = defineProps<SliderThumbProps>()
+const props = withDefaults(defineProps<SliderThumbProps>(), {
+  as: 'span',
+})
 const { getItems } = useCollection()
 
 const { forwardRef, currentElement: thumbElement } = useForwardExpose()

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`'description': '<p>The element or component this component should render as. Can be overwritten by <code>asChild</code>.</p>\n',`
`7`	`7`	`'type': 'AsTag \| Component',`
`8`	`8`	`'required': false,`
`9`		`- 'default': '\'div\''`
	`9`	`+ 'default': '\'span\''`
`10`	`10`	`},`
`11`	`11`	`{`
`12`	`12`	`'name': 'asChild',`