fix: toRefs warning when passing in computed (#1963)

zernonia · web-flow · commit 1474cca5daca · 2025-05-31T18:13:48.000+08:00
* chore: revert useForwardProps changes

* fix: expose warning

* fix: test
diff --git a/packages/core/src/Slider/story/_Slider.vue b/packages/core/src/Slider/story/_Slider.vue
@@ -4,7 +4,9 @@ import { ref } from 'vue'
 import { useForwardPropsEmits } from '@/shared'
 import { SliderRange, SliderRoot, SliderThumb, SliderTrack } from '..'
 
-const props = defineProps<SliderRootProps>()
+const props = withDefaults(defineProps<SliderRootProps>(), {
+  inverted: false,
+})
 const emits = defineEmits<SliderRootEmits>()
 
 const sliderValue = ref([50])
diff --git a/packages/core/src/Stepper/StepperRoot.vue b/packages/core/src/Stepper/StepperRoot.vue
@@ -82,7 +82,6 @@ defineSlots<{
 
 const { dir: propDir, orientation: propOrientation, linear } = toRefs(props)
 const dir = useDirection(propDir)
-useForwardExpose()
 
 const totalStepperItems = ref<Set<HTMLElement>>(new Set())
 
@@ -174,6 +173,8 @@ defineExpose({
   hasNext,
   hasPrev,
 })
+
+useForwardExpose()
 </script>
 
 <template>
diff --git a/packages/core/src/shared/useForwardProps.ts b/packages/core/src/shared/useForwardProps.ts
@@ -1,5 +1,5 @@
 import type { MaybeRefOrGetter } from 'vue'
-import { camelize, computed, getCurrentInstance, toRef, toRefs } from 'vue'
+import { camelize, computed, getCurrentInstance, toRef } from 'vue'
 
 interface PropOptions {
   type?: any
@@ -26,7 +26,6 @@ export function useForwardProps<T extends Record<string, any>>(props: MaybeRefOr
 
   const refProps = toRef(props)
   return computed(() => {
-    const propsAsRefs = toRefs(refProps.value)
     const preservedProps = {} as T
     const assignedProps = vm?.vnode.props ?? {}
 
@@ -36,9 +35,8 @@ export function useForwardProps<T extends Record<string, any>>(props: MaybeRefOr
 
     // Only return value from the props parameter
     return Object.keys({ ...defaultProps, ...preservedProps }).reduce((prev, curr) => {
-      const val = propsAsRefs[curr]?.value
-      if (val !== undefined)
-        prev[curr as keyof T] = val
+      if (refProps.value[curr] !== undefined)
+        prev[curr as keyof T] = refProps.value[curr]
       return prev
     }, {} as T)
   })
