| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 21:33:20 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=279.991759,conversation_content-fragment;desc="conversation_content fragment";dur=851.942774,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=236.765054,nginx;desc="NGINX";dur=0.90603,glb;desc="GLB";dur=137.872068
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Qg1tPSWT4KF6ojVBGueEupg7YS2B%2FERVagJnfP7gWZsMVTEWXw8%2FAvwQQwGWwJke1APkfQaYKdgEMWel%2BDFT1x87n8YWaQTS9lr7OVC94cnM%2BKG16eGQEiiCDQCv6VK4ouNi10w14mcShAyWdwWhgpAeoqRv%2Fwkcy567%2FTVRr9wNQK%2B2aCEHFD1cQ7tLnuNcg1CSrt2QpuVf4CAkTwQWnox5ukrB8pspey29VFFR%2FueRdMPSRZelOt1Ex9yXuhUEzTwSnHS459MIAobIBCKQ3g%3D%3D--gxWmS3Fk6U8L%2BFrW--d%2B8J6neAnoZgi1nGPxYNIg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.783765735.1760218399; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 21:33:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 21:33:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DD7A:366CA0:A7BC05:DC85D3:68EACD1F
Upgrade array-changes to fix structural moves by sunesimonsen · Pull Request #860 · unexpectedjs/unexpected · GitHub
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
July 30, 2025 09:56
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
July 31, 2025 09:27
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 25
Upgrade array-changes to fix structural moves #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunesimonsen
wants to merge
1
commit into
master
Choose a base branch
from
ssimonsen/upgrade-array-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
cd4b9fc to
5bf0333
Compare
papandreou
reviewed
Jul 30, 2025
| @@ -0,0 +1,25 @@ | |||
| const arrayChanges = require('array-changes'); | |||
|
|
|||
| module.exports = function (...args) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we now need to wrap array-changes I guess we could consider making these adjustments directly in the library, or maybe even just copy the whole thing in here. I don't see this as a blocker, just an observation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do that, because I think we should consider showing the similar diff with a move. I just don't want to make that change right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhh maybe you are right, maybe we don't want to see moves for similar items. Could we merge this, then I'll add an issue to upstream the change into array-changes itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, absolutely!
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
5bf0333 to
57c21c0
Compare
papandreou
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In the previous version of array-changes we didn't manage to correctly show structural similar moves, we would just show the actual item being moved.
I opted for just showing a remove and an insert instead of showing a structural diff that is then moved. That simplifies things a bit, but we can always change our minds on this decision.
The plugin failures seems reasonable.