un-ts
diff --git a/‎.changeset/fresh-worms-suffer.md
Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions b/‎.changeset/fresh-worms-suffer.md
Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions
diff --git a/‎.github/workflows/pkg-size.yml
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎.github/workflows/pkg-size.yml
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎.github/workflows/size-limit.yml
Copy file name to clipboard
+2-1Lines changed: 2 additions & 1 deletion b/‎.github/workflows/size-limit.yml
Copy file name to clipboard
+2-1Lines changed: 2 additions & 1 deletion
diff --git a/‎.github/workflows/vercel.yml
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion b/‎.github/workflows/vercel.yml
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion
diff --git a/‎.size-limit.json
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎.size-limit.json
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎package.json
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎package.json
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/constants.ts
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion b/‎src/constants.ts
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion
diff --git a/‎src/helpers.ts
Copy file name to clipboard
+15-3Lines changed: 15 additions & 3 deletions b/‎src/helpers.ts
Copy file name to clipboard
+15-3Lines changed: 15 additions & 3 deletions
diff --git a/‎src/index.ts
Copy file name to clipboard
+73-19Lines changed: 73 additions & 19 deletions b/‎src/index.ts
Copy file name to clipboard
+73-19Lines changed: 73 additions & 19 deletions
diff --git a/‎test/basic.spec.ts
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎test/basic.spec.ts
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
@@ -0,0 +1,5 @@
+---
+"napi-postinstall": patch
+---
+
+fix: give up patching `yarn` pnp automatically which is impossible
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Checkout
+      - name: Checkout Repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
 
       - name: Package Size Report
 
@@ -13,7 +13,8 @@ jobs:
   size-limit:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - name: Checkout Repo
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
 
       - name: Setup Node.js LTS
         uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
 
@@ -12,9 +12,11 @@ concurrency:
 
 jobs:
   deploy:
+    if: ${{ !github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - name: Checkout Repo
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
 
       - name: Check Branch
         id: branch
 
@@ -1,6 +1,6 @@
 [
   {
     "path": "./lib/index.js",
-    "limit": "2.6kB"
+    "limit": "3kB"
   }
 ]
@@ -42,7 +42,7 @@
     "test": "vitest run",
     "typecov": "type-coverage",
     "vercel-build": "yarn docs:build",
-    "version": "changeset version && yarn --no-immutable && yarn test"
+    "version": "changeset version && yarn --no-immutable && yarn test -u"
   },
   "devDependencies": {
     "@1stg/browserslist-config": "^2.1.4",
 
@@ -4,10 +4,12 @@ import { PackageJson } from './types.js'
 
 export const DEFAULT_NPM_REGISTRY = 'https://registry.npmjs.org/'
 
-export const { name, version } = require(
+export const meta = require(
   path.resolve(__dirname, '../package.json'),
 ) as PackageJson
 
+const { name, version } = meta
+
 export const LOG_PREFIX = `[${name}@${version}] `
 
 export const WASM32 = 'wasm32'
 
@@ -2,7 +2,7 @@ import { execSync } from 'node:child_process'
 import * as fs from 'node:fs'
 import * as path from 'node:path'
 
-import { DEFAULT_NPM_REGISTRY } from './constants.js'
+import { DEFAULT_NPM_REGISTRY, LOG_PREFIX } from './constants.js'
 import { parseTriple } from './target.js'
 import { NapiInfo, PackageJson } from './types.js'
 
@@ -59,7 +59,9 @@ export function getNapiInfoFromPackageJson(
 
   if (!targets?.length) {
     throw new Error(
-      `No \`napi.targets\` nor \`napi.triples.additional\` field found in \`${name}\`'s \`package.json\`. Please ensure the package is built with NAPI support.`,
+      errorMessage(
+        `No \`napi.targets\` nor \`napi.triples.additional\` field found in \`${name}\`'s \`package.json\`. Please ensure the package is built with NAPI support.`,
+      ),
     )
   }
 
@@ -90,7 +92,9 @@ export function getNapiInfoFromPackageJson(
     if (version) {
       if (checkVersion && version !== packageVersion) {
         throw new Error(
-          `Inconsistent package versions found for \`${name}\` with \`${pkg}\` v${packageVersion} vs v${version}.`,
+          errorMessage(
+            `Inconsistent package versions found for \`${name}\` with \`${pkg}\` v${packageVersion} vs v${version}.`,
+          ),
         )
       }
     } else if (packageVersion) {
@@ -268,3 +272,11 @@ export function getNapiNativeTargets() {
 export function getErrorMessage(err: unknown) {
   return (err as Error | undefined)?.message || String(err)
 }
+
+export function errorLog(message: string, ...args: unknown[]) {
+  console.error(`${LOG_PREFIX}${message}`, ...args)
+}
+
+export function errorMessage(message: string, extra?: string) {
+  return `${LOG_PREFIX}${message}` + (extra ? ': ' + extra : '')
+}
@@ -6,9 +6,11 @@ import * as https from 'node:https'
 import * as path from 'node:path'
 import * as zlib from 'node:zlib'
 
-import { LOG_PREFIX, PACKAGE_JSON, WASM32, WASM32_WASI } from './constants.js'
+import { meta, PACKAGE_JSON, WASM32, WASM32_WASI } from './constants.js'
 import {
   downloadedNodePath,
+  errorLog,
+  errorMessage,
   getErrorMessage,
   getGlobalNpmRegistry,
   getNapiInfoFromPackageJson,
@@ -46,7 +48,7 @@ function extractFileFromTarGzip(buffer: Buffer, subpath: string) {
     buffer = zlib.unzipSync(buffer)
   } catch (err) {
     throw new Error(
-      `Invalid gzip data in archive: ${(err as Error | undefined)?.message || String(err)}`,
+      errorMessage(`Invalid gzip data in archive`, getErrorMessage(err)),
     )
   }
   const str = (i: number, n: number) =>
@@ -65,11 +67,15 @@ function extractFileFromTarGzip(buffer: Buffer, subpath: string) {
       offset += (size + 511) & ~511
     }
   }
-  throw new Error(`Could not find ${JSON.stringify(subpath)} in archive`)
+  throw new Error(errorMessage(`Could not find \`${subpath}\` in archive`))
 }
 
 export function isNpm() {
-  return !!process.env.npm_config_user_agent?.startsWith('npm/')
+  return process.env.npm_config_user_agent?.startsWith('npm/')
+}
+
+export function isPnp() {
+  return !!process.versions.pnp
 }
 
 // eslint-disable-next-line sonarjs/cognitive-complexity
@@ -94,7 +100,22 @@ function installUsingNPM(
   // "package.json" file. We'll use this to run "npm install" in.
   const pkgDir = path.dirname(require.resolve(hostPkg + `/${PACKAGE_JSON}`))
   const installDir = path.join(pkgDir, 'npm-install')
-  fs.mkdirSync(installDir, { recursive: true })
+  try {
+    fs.mkdirSync(installDir, { recursive: true })
+  } catch (err) {
+    const error = err as NodeJS.ErrnoException
+    if (error.code === 'EROFS') {
+      // This can happen if the package is installed in a read-only location
+      // (e.g. "node_modules" inside a read-only directory). In this case, we
+      // can't install the package and should just give up.
+      errorLog(
+        `Failed to create the temporary directory on read-only location: ${error.message}`,
+      )
+      errorLog(`You have to install \`${pkg}\` manually in this case.`)
+      return
+    }
+    throw err
+  }
   try {
     const packageJsonPath = path.join(installDir, PACKAGE_JSON)
 
@@ -211,16 +232,14 @@ async function downloadDirectlyFromNPM(
   // If that fails, the user could have npm configured incorrectly or could not
   // have npm installed. Try downloading directly from npm as a last resort.
   const url = `${getGlobalNpmRegistry()}${pkg}/-/${pkg.startsWith('@') ? pkg.split('/')[1] : pkg}-${version}.tgz`
-  console.error(`${LOG_PREFIX}Trying to download ${JSON.stringify(url)}`)
+  errorLog(`Trying to download ${JSON.stringify(url)}`)
   try {
     fs.writeFileSync(
       nodePath,
       extractFileFromTarGzip(await fetch(url), subpath),
     )
   } catch (err) {
-    console.error(
-      `${LOG_PREFIX}Failed to download ${JSON.stringify(url)}: ${getErrorMessage(err)}`,
-    )
+    errorLog(`Failed to download ${JSON.stringify(url)}`, getErrorMessage(err))
     throw err
   }
 }
@@ -251,7 +270,9 @@ export async function checkAndPreparePackage(
       // could fail with `pnpm`, `yarn` v2+, etc, fallback to load from npm registry instead
       if (typeof versionOrCheckVersion !== 'string') {
         throw new TypeError(
-          `Failed to load \`${PACKAGE_JSON}\` from "${packageNameOrPackageJson}", please provide a version.`,
+          errorMessage(
+            `Failed to load \`${PACKAGE_JSON}\` from \`${packageNameOrPackageJson}\`, please provide a version.`,
+          ),
         )
       }
       const pkg = packageNameOrPackageJson
@@ -281,7 +302,9 @@ export async function checkAndPreparePackage(
 
   if (checkVersion && pkgVersion !== version) {
     throw new Error(
-      `Inconsistent package versions found for \`${name}\` v${pkgVersion} vs \`${napi.packageName}\` v${version}.`,
+      errorMessage(
+        `Inconsistent package versions found for \`${name}\` v${pkgVersion} vs \`${napi.packageName}\` v${version}.`,
+      ),
     )
   }
 
@@ -294,17 +317,35 @@ export async function checkAndPreparePackage(
       continue
     }
 
+    const isWasm32Wasi = target === WASM32_WASI
+
     const binaryPrefix = napi.binaryName ? `${napi.binaryName}.` : ''
-    const subpath = `${binaryPrefix}${target}.${target === WASM32_WASI ? 'wasm' : 'node'}`
+    const subpath = `${binaryPrefix}${target}.${isWasm32Wasi ? 'wasm' : 'node'}`
 
     try {
       // First check for the binary package from our "optionalDependencies". This
       // package should have been installed alongside this package at install time.
       require.resolve(`${pkg}/${subpath}`)
       break
     } catch {
+      if (isPnp()) {
+        if (isWasm32Wasi) {
+          try {
+            // eslint-disable-next-line sonarjs/os-command
+            execSync(`yarn add -D ${pkg}@${version}`)
+          } catch (err) {
+            errorLog(
+              `Failed to install package \`${pkg}\` automatically in the yarn P'n'P environment`,
+              getErrorMessage(err),
+            )
+            errorLog("You'll have to install it manually in this case.")
+          }
+        }
+        return
+      }
+
       if (!isNpm()) {
-        console.error(`${LOG_PREFIX}Failed to find package "${pkg}" on the file system
+        errorLog(`Failed to find package "${pkg}" on the file system
 
 This can happen if you use the "--no-optional" flag. The "optionalDependencies"
 ${PACKAGE_JSON} feature is used by ${name} to install the correct napi binary
@@ -322,16 +363,26 @@ this. If that fails, you need to remove the "--no-optional" flag to use ${name}.
       // cases that fail because people have customized their environment in
       // some strange way that breaks downloading. This code path is just here
       // to be helpful but it's not the supported way of installing <napi>.
-      const nodePath = downloadedNodePath(name, subpath)
+      let nodePath: string
       try {
-        console.error(
-          `${LOG_PREFIX}Trying to install package "${pkg}" using npm`,
+        nodePath = downloadedNodePath(name, subpath)
+      } catch {
+        // could fail with `yarn` P'n'P or unknown situation, try our best to
+        // guess the path from current location
+        const nodeModulesDir = path.resolve(
+          require.resolve(meta.name + `/${PACKAGE_JSON}`),
+          '../..',
         )
+        nodePath = path.join(nodeModulesDir, name, subpath)
+      }
+      try {
+        errorLog(`Trying to install package "${pkg}" using npm`)
         installUsingNPM(name, pkg, version, target, subpath, nodePath)
         break
       } catch (err) {
-        console.error(
-          `${LOG_PREFIX}Failed to install package "${pkg}" using npm: ${getErrorMessage(err)}`,
+        errorLog(
+          `Failed to install package "${pkg}" using npm`,
+          getErrorMessage(err),
         )
 
         // If that didn't also work, then something is likely wrong with the "npm"
@@ -342,7 +393,10 @@ this. If that fails, you need to remove the "--no-optional" flag to use ${name}.
           break
         } catch (err) {
           throw new Error(
-            `Failed to install package "${pkg}": ${getErrorMessage(err)}`,
+            errorMessage(
+              `Failed to install package "${pkg}"`,
+              getErrorMessage(err),
+            ),
           )
         }
       }
 
@@ -18,7 +18,7 @@ describe('napi-postinstall', () => {
     await expect(
       checkAndPreparePackage('napi-postinstall'),
     ).rejects.toThrowErrorMatchingInlineSnapshot(
-      `[Error: No \`napi.targets\` nor \`napi.triples.additional\` field found in \`napi-postinstall\`'s \`package.json\`. Please ensure the package is built with NAPI support.]`,
+      `[Error: [napi-postinstall@0.2.1] No \`napi.targets\` nor \`napi.triples.additional\` field found in \`napi-postinstall\`'s \`package.json\`. Please ensure the package is built with NAPI support.]`,
     )
   })
 })
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"napi-postinstall": patch
 +---
++
 +fix: give up patching `yarn` pnp automatically which is impossible
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"path": "./lib/index.js",`
`4`		`- "limit": "2.6kB"`
	`4`	`+ "limit": "3kB"`
`5`	`5`	`}`
`6`	`6`	`]`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ describe('napi-postinstall', () => {`
`18`	`18`	`await expect(`
`19`	`19`	`checkAndPreparePackage('napi-postinstall'),`
`20`	`20`	`).rejects.toThrowErrorMatchingInlineSnapshot(`
`21`		- `[Error: No \`napi.targets\` nor \`napi.triples.additional\` field found in \`napi-postinstall\`'s \`package.json\`. Please ensure the package is built with NAPI support.]`,
	`21`	+ `[Error: [napi-postinstall@0.2.1] No \`napi.targets\` nor \`napi.triples.additional\` field found in \`napi-postinstall\`'s \`package.json\`. Please ensure the package is built with NAPI support.]`,
`22`	`22`	`)`
`23`	`23`	`})`
`24`	`24`	`})`