fix: take context.cwd into account for glob options of several rules (#371)

dword-design · JounQin · web-flow · commit 4f97a1a1419c · 2025-06-05T21:35:08.000+08:00
Co-authored-by: JounQin &lt;admin@1stg.me&gt;
diff --git a/.changeset/rude-cherries-fly.md b/.changeset/rude-cherries-fly.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix: take `context.cwd` into account for glob options of rules `no-extraneous-dependencies` and `no-unassigned-import`
diff --git a/.changeset/serious-mails-provide.md b/.changeset/serious-mails-provide.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix: enable `nocomment: true` for glob options of rules `no-import-module-exports` and `no-namespace`
diff --git a/src/rules/no-extraneous-dependencies.ts b/src/rules/no-extraneous-dependencies.ts
@@ -328,15 +328,22 @@ function reportIfMissing(
   })
 }
 
-function testConfig(config: string[] | boolean | undefined, filename: string) {
+function testConfig(
+  config: string[] | boolean | undefined,
+  context: RuleContext,
+) {
   // Simplest configuration first, either a boolean or nothing.
   if (typeof config === 'boolean' || config === undefined) {
     return config
   }
+  const filename = context.physicalFilename
   // Array of globs.
   return config.some(
     c =>
       minimatch(filename, c) ||
+      minimatch(filename, path.resolve(context.cwd, c), {
+        windowsPathsNoEscape: true,
+      }) ||
       minimatch(filename, path.resolve(c), { windowsPathsNoEscape: true }),
   )
 }
@@ -398,18 +405,15 @@ export default createRule<[Options?], MessageId>({
   create(context) {
     const options = context.options[0] || {}
 
-    const filename = context.physicalFilename
-
     const deps =
       getDependencies(context, options.packageDir) || extractDepFields({})
 
     const depsOptions = {
-      allowDevDeps: testConfig(options.devDependencies, filename) !== false,
-      allowOptDeps:
-        testConfig(options.optionalDependencies, filename) !== false,
-      allowPeerDeps: testConfig(options.peerDependencies, filename) !== false,
+      allowDevDeps: testConfig(options.devDependencies, context) !== false,
+      allowOptDeps: testConfig(options.optionalDependencies, context) !== false,
+      allowPeerDeps: testConfig(options.peerDependencies, context) !== false,
       allowBundledDeps:
-        testConfig(options.bundledDependencies, filename) !== false,
+        testConfig(options.bundledDependencies, context) !== false,
       verifyInternalDeps: !!options.includeInternal,
       verifyTypeImports: !!options.includeTypes,
     }
diff --git a/src/rules/no-import-module-exports.ts b/src/rules/no-import-module-exports.ts
@@ -112,7 +112,9 @@ export default createRule<[Options?], MessageId>({
           isIdentifier &&
           hasCJSExportReference &&
           !isEntryPoint &&
-          !options.exceptions?.some(glob => minimatch(filename, glob)) &&
+          !options.exceptions?.some(glob =>
+            minimatch(filename, glob, { nocomment: true }),
+          ) &&
           !isImportBinding
         ) {
           for (const importDeclaration of importDeclarations) {
diff --git a/src/rules/no-namespace.ts b/src/rules/no-namespace.ts
@@ -47,7 +47,10 @@ export default createRule<[Options?], MessageId>({
       ImportNamespaceSpecifier(node) {
         if (
           ignoreGlobs?.find(glob =>
-            minimatch(node.parent.source.value, glob, { matchBase: true }),
+            minimatch(node.parent.source.value, glob, {
+              matchBase: true,
+              nocomment: true,
+            }),
           )
         ) {
           return
diff --git a/src/rules/no-unassigned-import.ts b/src/rules/no-unassigned-import.ts
@@ -1,18 +1,21 @@
 import path from 'node:path'
 
+import type { RuleContext } from 'eslint-import-context'
 import { minimatch } from 'minimatch'
 
 import { isStaticRequire, createRule } from '../utils/index.js'
 
 function testIsAllow(
   globs: string[] | undefined,
-  filename: string,
+  context: RuleContext,
   source: string,
 ) {
   if (!Array.isArray(globs)) {
     return false // default doesn't allow any patterns
   }
 
+  const filename = context.physicalFilename
+
   const filePath =
     // a node module
     source[0] !== '.' && source[0] !== '/'
@@ -22,6 +25,10 @@ function testIsAllow(
   return globs.some(
     glob =>
       minimatch(filePath, glob, { nocomment: true }) ||
+      minimatch(filePath, path.resolve(context.cwd, glob), {
+        nocomment: true,
+        windowsPathsNoEscape: true,
+      }) ||
       minimatch(filePath, path.resolve(glob), {
         nocomment: true,
         windowsPathsNoEscape: true,
@@ -68,10 +75,8 @@ export default createRule<[Options?], MessageId>({
   create(context) {
     const options = context.options[0] || {}
 
-    const filename = context.physicalFilename
-
     const isAllow = (source: string) =>
-      testIsAllow(options.allow, filename, source)
+      testIsAllow(options.allow, context, source)
 
     return {
       ImportDeclaration(node) {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"eslint-plugin-import-x": patch
 +---
++
 +fix: take `context.cwd` into account for glob options of rules `no-extraneous-dependencies` and `no-unassigned-import`