You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
ECMA-402 currently specifies the strings "BC" and "AD", but it makes sense to me to make the test robust for a change to BCE/CE nomenclature in the future.
If I understand correctly, we don't actually need to wait for tc39/ecma402#723 to achieve consensus in order to merge this? The test as written already reflects web reality, and disagrees with the spec text. This PR just improves the test, right? (Edit: never mind; I was looking at only the second commit when I wrote this. Still approved, but we do need to wait for the ECMA-402 PR.)
awaiting consensusThis needs committee consensus before it can be eligible to be merged.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref tc39/ecma402#723