fixes permutation of types in heurisch #26940

smichr · 2024-08-09T20:58:42Z

References to other Issues or PRs

closes #26922
closes #26930
closes #26934 as alternative to reversion

cf #26358

Brief description of what is fixed or changed

Type of expressions (not the tuple containing the expression and replacement) are now permuted.

Other comments

Release Notes

integrals
- A regression introduced in SymPy 1.13 in the heurisch integration routine was fixed. The regression prevented some integrals from being evaluated.

sympy-bot · 2024-08-09T20:58:48Z

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

integrals
- A regression introduced in SymPy 1.13 in the heurisch integration routine was fixed. The regression prevented some integrals from being evaluated. (#26940 by @oscarbenjamin, @smichr, and @sylee957)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.2.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
closes #26922 
closes #26930 
closes #26934 as alternative to reversion
cf #26358
#### Brief description of what is fixed or changed
Type of *expressions* (not the tuple containing the expression and replacement) are now permuted.
#### Other comments
#### Release Notes
<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:
* solvers
  * Added a new solver for logarithmic equations.
* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.
* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.
or if no release note(s) should be included use:
NO ENTRY
See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->
<!-- BEGIN RELEASE NOTES -->
* integrals
   * A regression introduced in SymPy 1.13 in the heurisch integration routine was fixed. The regression prevented some integrals from being evaluated.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

github-actions · 2024-08-09T23:48:01Z

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

| Change   | Before [a36a8b23] <sympy-1.12.1^0>   | After [5b2c92a8]    |   Ratio | Benchmark (Parameter)                                                |
|----------|--------------------------------------|---------------------|---------|----------------------------------------------------------------------|
| -        | 73.4±0.9ms                           | 45.8±0.4ms          |    0.62 | integrate.TimeIntegrationRisch02.time_doit(10)                       |
| -        | 69.3±0.8ms                           | 45.2±0.3ms          |    0.65 | integrate.TimeIntegrationRisch02.time_doit_risch(10)                 |
| +        | 18.4±0.5μs                           | 30.8±0.2μs          |    1.68 | integrate.TimeIntegrationRisch03.time_doit(1)                        |
| -        | 5.47±0.05ms                          | 2.91±0.03ms         |    0.53 | logic.LogicSuite.time_load_file                                      |
| -        | 74.5±0.3ms                           | 28.5±0.2ms          |    0.38 | polys.TimeGCD_GaussInt.time_op(1, 'dense')                           |
| -        | 26.1±0.3ms                           | 17.2±0.1ms          |    0.66 | polys.TimeGCD_GaussInt.time_op(1, 'expr')                            |
| -        | 74.6±0.4ms                           | 29.2±0.04ms         |    0.39 | polys.TimeGCD_GaussInt.time_op(1, 'sparse')                          |
| -        | 258±1ms                              | 126±0.8ms           |    0.49 | polys.TimeGCD_GaussInt.time_op(2, 'dense')                           |
| -        | 259±2ms                              | 124±0.6ms           |    0.48 | polys.TimeGCD_GaussInt.time_op(2, 'sparse')                          |
| -        | 665±6ms                              | 373±3ms             |    0.56 | polys.TimeGCD_GaussInt.time_op(3, 'dense')                           |
| -        | 661±2ms                              | 373±2ms             |    0.57 | polys.TimeGCD_GaussInt.time_op(3, 'sparse')                          |
| -        | 508±2μs                              | 291±3μs             |    0.57 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense')            |
| -        | 1.87±0.02ms                          | 1.09±0.01ms         |    0.58 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense')            |
| -        | 5.88±0.1ms                           | 3.13±0.02ms         |    0.53 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense')            |
| -        | 464±3μs                              | 235±2μs             |    0.51 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense')               |
| -        | 1.51±0.01ms                          | 697±2μs             |    0.46 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense')               |
| -        | 4.99±0.1ms                           | 1.69±0.02ms         |    0.34 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense')               |
| -        | 382±2μs                              | 211±1μs             |    0.55 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense')                |
| -        | 2.51±0.03ms                          | 1.25±0.01ms         |    0.5  | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense')                |
| -        | 10.2±0.2ms                           | 4.46±0.02ms         |    0.44 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense')                |
| -        | 371±4μs                              | 175±1μs             |    0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense')            |
| -        | 2.56±0.04ms                          | 930±7μs             |    0.36 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense')            |
| -        | 9.93±0.07ms                          | 2.67±0.03ms         |    0.27 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense')            |
| -        | 1.03±0.02ms                          | 429±4μs             |    0.42 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense')           |
| -        | 1.75±0.01ms                          | 502±3μs             |    0.29 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')          |
| -        | 5.85±0.05ms                          | 1.76±0.01ms         |    0.3  | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense')           |
| -        | 8.35±0.04ms                          | 1.51±0.01ms         |    0.18 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')          |
| -        | 284±0.9μs                            | 65.4±0.3μs          |    0.23 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')             |
| -        | 3.37±0.02ms                          | 393±5μs             |    0.12 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense')              |
| -        | 3.95±0.03ms                          | 280±5μs             |    0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')             |
| -        | 6.87±0.06ms                          | 1.26±0.01ms         |    0.18 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense')              |
| -        | 8.59±0.06ms                          | 845±6μs             |    0.1  | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')             |
| -        | 5.21±0.02ms                          | 2.97±0.01ms         |    0.57 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| -        | 12.4±0.2ms                           | 6.67±0.04ms         |    0.54 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense')  |
| -        | 22.9±0.2ms                           | 9.03±0.04ms         |    0.39 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| -        | 5.25±0.03ms                          | 868±2μs             |    0.17 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')    |
| -        | 12.7±0.08ms                          | 7.01±0.02ms         |    0.55 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')    |
| -        | 100±0.4ms                            | 26.1±0.08ms         |    0.26 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense')     |
| -        | 168±0.7ms                            | 53.9±0.1ms          |    0.32 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')    |
| -        | 178±1μs                              | 115±0.6μs           |    0.64 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense')      |
| -        | 362±6μs                              | 214±3μs             |    0.59 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse')     |
| -        | 4.26±0.03ms                          | 865±5μs             |    0.2  | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense')      |
| -        | 5.21±0.08ms                          | 389±7μs             |    0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')     |
| -        | 19.8±0.2ms                           | 2.85±0.03ms         |    0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense')      |
| -        | 22.3±0.1ms                           | 625±4μs             |    0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')     |
| -        | 486±1μs                              | 137±3μs             |    0.28 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| -        | 4.69±0.04ms                          | 609±4μs             |    0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense')  |
| -        | 5.26±0.05ms                          | 140±0.6μs           |    0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| -        | 12.9±0.1ms                           | 1.27±0ms            |    0.1  | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense')  |
| -        | 13.9±0.07ms                          | 143±0.5μs           |    0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| -        | 136±0.7μs                            | 76.5±0.6μs          |    0.56 | solve.TimeMatrixOperations.time_rref(3, 0)                           |
| -        | 253±0.9μs                            | 92.3±0.4μs          |    0.36 | solve.TimeMatrixOperations.time_rref(4, 0)                           |
| -        | 24.8±0.2ms                           | 10.4±0.03ms         |    0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys                       |
| -        | 29.2±0.2ms                           | 15.8±0.2ms          |    0.54 | solve.TimeSparseSystem.time_linsolve_Aaug(20)                        |
| -        | 55.8±0.3ms                           | 25.9±0.2ms          |    0.46 | solve.TimeSparseSystem.time_linsolve_Aaug(30)                        |
| -        | 28.7±0.3ms                           | 15.8±0.1ms          |    0.55 | solve.TimeSparseSystem.time_linsolve_Ab(20)                          |
| -        | 55.1±0.2ms                           | 25.7±0.2ms          |    0.47 | solve.TimeSparseSystem.time_linsolve_Ab(30)                          |

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

smichr and others added 3 commits August 9, 2024 15:54

sort by type of expression in heurisch

ea187ff

test(integrals): add back deleted test

d491fde

non-reversed ordering of expr in mapping

46b43f1

oscarbenjamin added this to the SymPy 1.13 milestone Aug 9, 2024

oscarbenjamin added the integrals.heurisch label Aug 9, 2024

sylee957 and others added 5 commits August 9, 2024 23:01

Remove duplicate module

655e46a

maint(ci): Add bleeding edge dependencies job

60f2930

Comment unneeded variables

13fc04c

Commend unneeded mport

3b040db

maint(ci): install libmpc in bleeding edge job

9ddff22

oscarbenjamin merged commit 863fc64 into sympy:1.13 Aug 9, 2024
53 checks passed

smichr mentioned this pull request Sep 16, 2024

Heurisch is over permuting and breaking required solution order #26359

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fixes permutation of types in heurisch #26940

fixes permutation of types in heurisch #26940

Uh oh!

smichr commented Aug 9, 2024 •

edited by oscarbenjamin

Loading

Uh oh!

sympy-bot commented Aug 9, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fixes permutation of types in heurisch #26940

fixes permutation of types in heurisch #26940

Uh oh!

Conversation

smichr commented Aug 9, 2024 • edited by oscarbenjamin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

Uh oh!

sympy-bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

smichr commented Aug 9, 2024 •

edited by oscarbenjamin

Loading

sympy-bot commented Aug 9, 2024 •

edited

Loading