| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:54:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=340.317944,conversation_content-fragment;desc="conversation_content fragment";dur=860.785592,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=372.905998,nginx;desc="NGINX";dur=0.658695,glb;desc="GLB";dur=100.872807
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CHQIZcScvq3TTnpoql8lNctPfSVQcXtMkbxvRKIBncWmoWfeJP%2BN4GEmyBImbicDiLHpzA%2BmV%2FKMR5AkgIwcZlRvSsBoeMz2OtajsaP15ceYg70rYBrCOpFtmOfjCfQC%2Fpo97MfWfyXjukOinJY9xYr12VIglQamBBf0e4U9i%2BV8chWkN3HKzulfEjcLZ0d9YboCHRizcOqqgiGqijppe1SCZHf%2B%2BPAi%2BXV0toBdZWYYWo8RBzPX4UyeYqJ7m8hVHR3Tyi9YieQJzxRl1RlNIA%3D%3D--aY8BBYJu6ftb7%2BfL--KpdaKJ%2BuRRjVv31yxLJESQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.828443606.1753966494; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:54:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:54:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8C24:33DAA7:A8912A:C7BD96:688B679E
fix combinatorics failures from repeated test runs by valglad · Pull Request #15167 · sympy/sympy · GitHub
valglad
changed the title
fix group theory failures from repeated test runs
fix combinatorics failures from repeated test runs
Aug 29, 2018
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix combinatorics failures from repeated test runs #15167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before introduction of the keyword `max_cosets`, the only way to control the maximum number of cosets in a coset enumeration was by changing the class attribute `coset_table_max_limit`. If not restored to the original value, the change in attribute affects all subsequent coset enumerations causing doctests to fail if run twice in the same process. This commit changes the tests to use `max_cosets` instead but also modifies the code of CosetTable to allow the attribute change to be preserved even if `max_cosets` is used after the change
|
âś… Hi, I am the SymPy bot (v129). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
valglad
changed the title
|
This seems to fix the recursion errors, but I still get doctest failures in combinatorics from doctest('comb', subprocess=False)
doctest('comb', subprocess=False) |
|
Oh scratch that I didn't see the latest commit. |
asmeurer
reviewed
Aug 29, 2018
| @@ -533,6 +534,7 @@ def rotate(self, perm): | |||
|
|
|||
| >>> from sympy.combinatorics import Polyhedron, Permutation | |||
| >>> from sympy.combinatorics.polyhedron import cube | |||
| >>> cube = cube.copy() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these objects are supposed to be imported and used like this it seems they shouldn't be mutable. Actually it looks like they are Basic instances, which shouldn't ever be mutable. I think either it should not be Basic, or the methods like rotate should return new instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of making them immutable but that would be a backward compatibility break, and I wasn't sure if it was worth it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can open a new issue about it. For now, this PR seems to fix the failures from the combinatorics and group modules, so I'm +1 to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Part of what's being done in #15163
See #15149 for other failures
Before the introduction of keyword
max_cosets, the only way tocontrol the maximum number of cosets in a coset enumeration was
by changing the class attribute
CosetTable.coset_table_max_limit. If notrestored to the original value, the change in attribute affects
all subsequent coset enumerations. This caused doctests to fail if run
twice in the same process. This PR changes the tests to use
max_cosetsinstead and modifies the code ofCosetTabletoallow the attribute change to be preserved even if
max_cosetsis used after the change.
The failures in
polyhedronwere due to the fact thatPolyhedronis a mutable object and the doctests imported pre-computed standard polyhedra (liketetrahedronandcube) and performed operations so that when they were imported next time, they were no longer in their standard state. I've changed doctests to create a copy firstRelease Notes
CosetTable.coset_table_max_limitis no longer overwritten whenmax_cosetskeyword is used