Update the signature of class-specific simplification methods #15033

normalhuman · 2018-08-04T20:59:52Z

References to other Issues or PRs

Brief description of what is fixed or changed

Updates the signature of various class-specific simplification methods _eval_simplify to include rational and inverse flags that are used by simplify function (which calls these methods). In case of log class, the inverse method is used right there; but usually these flags are passed through.

Release Notes

core
- fixed a bug in the simplification of inverses, such as simplify(log(exp(x)), inverse=True).

to include `rational` and `inverse` flags. In case of log class, the `inverse` method is used right there; but usually these flags are passed through.

sympy-bot · 2018-08-04T21:00:01Z

✅

Hi, I am the SymPy bot (v124). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
Fixes #15032
#### Brief description of what is fixed or changed
Updates the signature of various class-specific simplification methods `_eval_simplify` to include `rational` and `inverse` flags that are used by `simplify` function (which calls these methods). In case of log class, the `inverse` method is used right there; but usually these flags are passed through.
#### Release Notes
<!-- BEGIN RELEASE NOTES -->
* core
  * fixed a bug in the simplification of inverses, such as `simplify(log(exp(x)), inverse=True)`.
<!-- END RELEASE NOTES -->

Your release notes are in good order.

Here is what the release notes will look like:

core
- fixed a bug in the simplification of inverses, such as simplify(log(exp(x)), inverse=True). (#15033 by @normalhuman)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Update

The release notes on the wiki have been updated.

Updates the signature of various class-specific simplification methods

89a5633

to include `rational` and `inverse` flags. In case of log class, the `inverse` method is used right there; but usually these flags are passed through.

asmeurer approved these changes Aug 5, 2018

View reviewed changes

jksuom merged commit 74d8d52 into sympy:master Aug 5, 2018

normalhuman deleted the logexp branch August 5, 2018 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update the signature of class-specific simplification methods #15033

Update the signature of class-specific simplification methods #15033

Uh oh!

normalhuman commented Aug 4, 2018 •

edited

Loading

Uh oh!

sympy-bot commented Aug 4, 2018 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Update the signature of class-specific simplification methods #15033

Update the signature of class-specific simplification methods #15033

Uh oh!

Conversation

normalhuman commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References to other Issues or PRs

Brief description of what is fixed or changed

Release Notes

Uh oh!

sympy-bot commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

normalhuman commented Aug 4, 2018 •

edited

Loading

sympy-bot commented Aug 4, 2018 •

edited

Loading