feature #61176 [DoctrineBridge] Remove support for auto-mapping Doctrine entities to controller arguments (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 6e5a24c2ccfa · 2025-07-21T14:24:12.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [DoctrineBridge] Remove support for auto-mapping Doctrine entities to controller arguments | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Commits ------- b706416 [DoctrineBridge] Remove support for auto-mapping Doctrine entities to controller arguments
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -139,7 +139,7 @@ DoctrineBridge
    ```php
    $type = $extractor->getType(Foo::class, 'property');
    ```
-
+ * Remove support for auto-mapping Doctrine entities to controller arguments; use explicit mapping instead
  * Make `ProxyCacheWarmer` class `final`
 
 ExpressionLanguage
diff --git a/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php b/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php
@@ -189,9 +189,6 @@ private function getCriteria(Request $request, MapEntity $options, ObjectManager
             }
 
             return $criteria;
-        } elseif (null === $mapping) {
-            trigger_deprecation('symfony/doctrine-bridge', '7.1', 'Relying on auto-mapping for Doctrine entities is deprecated for argument $%s of "%s": declare the mapping using either the #[MapEntity] attribute or mapped route parameters.', $argument->getName(), method_exists($argument, 'getControllerName') ? $argument->getControllerName() : 'n/a');
-            $mapping = $request->attributes->keys();
         }
 
         if ($mapping && array_is_list($mapping)) {
diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 8.0
 ---
 
+ * Remove support for auto-mapping Doctrine entities to controller arguments; use explicit mapping instead
  * Make `ProxyCacheWarmer` class `final`
 
 7.4
diff --git a/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php b/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php
@@ -64,9 +64,6 @@ public function testResolveWithoutManager()
         $this->assertSame([], $resolver->resolve($request, $argument));
     }
 
-    /**
-     * @group legacy
-     */
     public function testResolveWithNoIdAndDataOptional()
     {
         $manager = $this->createMock(ObjectManager::class);
@@ -247,9 +244,6 @@ public static function idsProvider(): iterable
         yield ['foo'];
     }
 
-    /**
-     * @group legacy
-     */
     public function testResolveGuessOptional()
     {
         $manager = $this->createMock(ObjectManager::class);
@@ -262,11 +256,7 @@ public function testResolveGuessOptional()
         $argument = $this->createArgument('stdClass', new MapEntity(), 'arg', true);
 
         $metadata = $this->createMock(ClassMetadata::class);
-        $manager->expects($this->once())
-            ->method('getClassMetadata')
-            ->with('stdClass')
-            ->willReturn($metadata);
-
+        $manager->expects($this->never())->method('getClassMetadata');
         $manager->expects($this->never())->method('getRepository');
 
         $this->expectException(NearMissValueResolverException::class);

Original file line number	Diff line number	Diff line change
`@@ -189,9 +189,6 @@ private function getCriteria(Request $request, MapEntity $options, ObjectManager`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`return $criteria;`
`192`		`- } elseif (null === $mapping) {`
`193`		`- trigger_deprecation('symfony/doctrine-bridge', '7.1', 'Relying on auto-mapping for Doctrine entities is deprecated for argument $%s of "%s": declare the mapping using either the #[MapEntity] attribute or mapped route parameters.', $argument->getName(), method_exists($argument, 'getControllerName') ? $argument->getControllerName() : 'n/a');`
`194`		`- $mapping = $request->attributes->keys();`
`195`	`192`	`}`
`196`	`193`
`197`	`194`	`if ($mapping && array_is_list($mapping)) {`