[concourse] Add support for on_error Job attribute

kdvolder · kdvolder · commit 10d1e620ad15 · 2019-11-01T11:43:50.000-07:00
See: #383
diff --git a/headless-services/concourse-language-server/src/main/java/org/springframework/ide/vscode/concourse/PipelineYmlSchema.java b/headless-services/concourse-language-server/src/main/java/org/springframework/ide/vscode/concourse/PipelineYmlSchema.java
@@ -418,6 +418,7 @@ public PipelineYmlSchema(ConcourseModel models, GithubInfoProvider github) {
 		addProp(job, "ensure",  step);
 		addProp(job, "on_success",  step);
 		addProp(job, "on_failure",  step);
+		addProp(job, "on_error",  step);
 		addProp(job, "on_abort", step);
 
 		AbstractType resourceType = f.ybean("ResourceType");
diff --git a/headless-services/concourse-language-server/src/main/resources/desc/Job/on_error.md b/headless-services/concourse-language-server/src/main/resources/desc/Job/on_error.md
@@ -0,0 +1 @@
+*Optional*. Step to execute when the job errors. Equivalent to the `on_error` step attribute.
diff --git a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java
@@ -3996,6 +3996,8 @@ public void gotoResourceTypeDefinition() throws Exception {
 				"      - get: code\n" +
 				"    on_failure:\n" +
 				"      put: code\n" +
+				"    on_error:\n" +
+				"      put: code\n" +
 				"    on_success:\n" +
 				"      put: code\n" +
 				"    ensure:\n" +
@@ -4020,6 +4022,7 @@ public void gotoResourceTypeDefinition() throws Exception {
 		editor.assertHoverContains("interruptible", "worker will not wait on the builds");
 		editor.assertHoverContains("on_success", "Step to execute when the job succeeds");
 		editor.assertHoverContains("on_failure", "Step to execute when the job fails");
+		editor.assertHoverContains("on_error", "Step to execute when the job errors");
 		editor.assertHoverContains("on_abort", "Step to execute when the job aborts");
 		editor.assertHoverContains("ensure", "Step to execute regardless");
 	}
@@ -4039,10 +4042,12 @@ public void gotoResourceTypeDefinition() throws Exception {
 				"      - get: a-resource\n" +
 				"    on_failure:\n" +
 				"      put: b-resource\n" +
+				"    on_error:\n" +
+				"      put: c-resource\n" +
 				"    on_success:\n" +
-				"      put: a-resource\n" +
+				"      put: d-resource\n" +
 				"    ensure:\n" +
-				"      put: c-resource\n" +
+				"      put: e-resource\n" +
 				"resources:\n" +
 				"- name: b-resource\n" +
 				"  type: git\n" +
@@ -4064,8 +4069,9 @@ public void gotoResourceTypeDefinition() throws Exception {
 				"nointerrupt|boolean",
 				"a-resource|resource does not exist",
 				"b-resource|should define 'branch'",
-				"a-resource|resource does not exist",
 				"c-resource|resource does not exist",
+				"d-resource|resource does not exist",
+				"e-resource|resource does not exist",
 				"code|Unused"
 		);
 	}
@@ -4089,6 +4095,7 @@ public void gotoResourceTypeDefinition() throws Exception {
 				"interruptible",
 				"max_in_flight",
 				"on_abort",
+				"on_error",
 				"on_failure",
 				"on_success",
 				"serial",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Optional. Step to execute when the job errors. Equivalent to the `on_error` step attribute.