| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 09:14:53 GMT
content-length: 0
location: https://github.com/spring-projects/spring-tools/pull/875
server-timing: nginx;desc="NGINX";dur=1.524858,glb;desc="GLB";dur=95.808777
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=qnotPP4vcfh5HUcB3fsPTfrIdOyV2IxSQ8IGprC2kLr5QNt1V9PYNWAXdTFWLRkxK%2Bqcv2urDfWA%2FgE5yl4Du7LCHKggl6hAeucZ%2Fj4tnQ8phzJAW7LOGrkqPe6wAQnfQe8XKMqEvnIY6iz%2FP9MSTZZwFYE3sB%2BkbfgTThLW%2Bb5SJD%2FX1NBth7hb14rq0Gkidz%2FN0owpqMFKxoCo61qfIFZiU46PYONFsQ7TH991z5cjahOLFbXE6Rkm%2FisRX8zhK1RwvIh6r%2B8VU0a6neLw0A%3D%3D--cE0qKS1ZlQ5039Og--wh49yAlOsWA3JzxaOes60g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1686489286.1753089293; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:14:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:14:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 977A:21B12E:180C2B2:1E808F7:687E050D
HTTP/2 200
date: Mon, 21 Jul 2025 09:14:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=295.90282,conversation_content-fragment;desc="conversation_content fragment";dur=649.696679,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=250.963762,nginx;desc="NGINX";dur=0.866405,glb;desc="GLB";dur=95.579321
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 977A:21B12E:180C335:1E8099E:687E050D
gcPauses -> jvm.gc.pause, memory -> jvm.memory.used by BoykoAlex · Pull Request #875 · spring-projects/spring-tools · GitHub
BoykoAlex
force-pushed
the
live-data-fix
branch
from
November 9, 2022 18:42
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 211
gcPauses -> jvm.gc.pause, memory -> jvm.memory.used #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2022
vudayani
reviewed
Nov 9, 2022
| @@ -232,7 +236,7 @@ private void scheduleRefresh(ProgressTask progressTask, SpringProcessParams spri | |||
|
|
|||
| try { | |||
| progressTask.progressEvent(progressMessage); | |||
| if(endpoint.equals("metrics") && metricName.equals("memory")) { | |||
| if(METRICS.equals(endpoint) && MEMORY.equals(metricName)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metricName passed from the API call here is ("memory", "gcPauses"). This is to identify the type of metric and not the actual metricName used for the actuator call. (Probably I should have named it metricType. But I wanted to keep the metricQuery more generic to be used for other metric calls.
The getMemoryMetrics function is where the metric names ("jvm.memory.used, jvm.memory.max") are passed.
Also, with the current implementation, the retrieveLiveMemoryMetricsData has the logic to fetch the heap and non-heap memory metrics together.
vudayani
reviewed
Nov 9, 2022
| SpringProcessGcPausesMetricsLiveData data = connectorService.getGcPausesMetricsLiveData(processKey); | ||
| return CompletableFuture.completedFuture(data.getGcPausesMetrics()); | ||
| } | ||
| case "memory": { | ||
| case SpringProcessConnectorService.MEMORY: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metricName passed here are ("gcPauses", "heapMemory", "nonHeapMemory"). This is used to fetch the region-specific metric data separately.
(This is the result of my bad naming convention again ;-) )
@BoykoAlex I would like to discuss and get your feedback on how to improve this.
BoykoAlex
force-pushed
the
live-data-fix
branch
from
aa9dbc4 to
c2acb0c
Compare
|
Closed with a411663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
gcPauses->jvm.gc.pause,memory->jvm.memory.used. Are those metric names different for other apps?Measurementsvalue asDoublerather thanLong@vudayani-vmw please have a look at this PR and provide feedback.