fix(iac): output URL for IaC to contain correct domain [IAC-3367]

ioannacaba · ioannacaba · commit 4ed65ccca6bc · 2025-06-12T10:27:01.000+03:00
diff --git a/src/lib/config/api-url.ts b/src/lib/config/api-url.ts
@@ -192,3 +192,13 @@ export function getRootUrl(apiUrlString: string): string {
   const rootUrl = apiUrl.protocol + '//' + apiUrl.host;
   return rootUrl;
 }
+
+export function getAppUrl(url: string): string {
+  const apiUrl = new URL(url);
+
+  if (apiUrl.host.startsWith('api.')) {
+    apiUrl.host = apiUrl.host.replace(/^api\./, 'app.');
+  }
+
+  return apiUrl.protocol + '//' + apiUrl.host;
+}
diff --git a/src/lib/formatters/iac-output/text/share-results.ts b/src/lib/formatters/iac-output/text/share-results.ts
@@ -1,6 +1,9 @@
-import config from '../../../config';
 import { EOL } from 'os';
 import { colors, contentPadding } from './utils';
+import { getAppUrl } from '../../../config/api-url';
+import config from '../../../config';
+
+const apiUrl = config.API;
 
 export function formatShareResultsOutput(orgName: string, projectName: string) {
   return (
@@ -9,7 +12,7 @@ export function formatShareResultsOutput(orgName: string, projectName: string) {
     EOL +
     contentPadding +
     'Your test results are available at: ' +
-    colors.title(`${config.ROOT}/org/${orgName}/projects`) +
+    colors.title(`${getAppUrl(apiUrl)}/org/${orgName}/projects`) +
     EOL +
     contentPadding +
     'under the name: ' +
@@ -28,9 +31,7 @@ export function formatShareResultsOutputIacPlus(
     contentPadding +
     'Your test results are available at: ' +
     colors.title(
-      `${
-        config.ROOT
-      }/org/${orgName}/cloud/issues?environment_name=${encodeURIComponent(
+      `${getAppUrl(apiUrl)}/org/${orgName}/cloud/issues?environment_name=${encodeURIComponent(
         projectName,
       )}`,
     )
@@ -43,7 +44,7 @@ export function formatShareResultsOutputIacV2(
 ) {
   let projectLink = ''; // empty link if projectId is undefined, will follow up on this after product decision
   if (projectPublicId) {
-    projectLink = `${config.ROOT}/org/${orgName}/project/${encodeURIComponent(projectPublicId)}`;
+    projectLink = `${getAppUrl(apiUrl)}/org/${orgName}/project/${encodeURIComponent(projectPublicId)}`;
   }
 
   return (
diff --git a/test/jest/unit/config/api-url.spec.ts b/test/jest/unit/config/api-url.spec.ts
@@ -3,6 +3,7 @@ import {
   getV1ApiUrl,
   getRestApiUrl,
   getRootUrl,
+  getAppUrl,
 } from '../../../../src/lib/config/api-url';
 
 const urls = [
@@ -12,83 +13,95 @@ const urls = [
     expectedV1: 'https://snyk.io/api/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://snyk.io',
+    expectedApp: 'https://snyk.io',
   },
   {
     userInput: 'https://snyk.io/api',
     expectedBase: 'https://snyk.io/api',
     expectedV1: 'https://snyk.io/api/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://snyk.io',
+    expectedApp: 'https://snyk.io',
   },
   {
     userInput: 'https://app.snyk.io/api',
     expectedBase: 'https://app.snyk.io/api',
     expectedV1: 'https://app.snyk.io/api/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://app.snyk.io',
+    expectedApp: 'https://app.snyk.io',
   },
   {
     userInput: 'https://app.snyk.io/api/v1',
     expectedBase: 'https://app.snyk.io/api/',
     expectedV1: 'https://app.snyk.io/api/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://app.snyk.io',
+    expectedApp: 'https://app.snyk.io',
   },
   {
     userInput: 'https://api.snyk.io/v1',
     expectedBase: 'https://api.snyk.io/',
     expectedV1: 'https://api.snyk.io/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://snyk.io',
+    expectedApp: 'https://app.snyk.io',
   },
   {
     userInput: 'https://api.snyk.io',
     expectedBase: 'https://api.snyk.io',
     expectedV1: 'https://api.snyk.io/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://snyk.io',
+    expectedApp: 'https://app.snyk.io',
   },
   {
     userInput: 'https://api.snyk.io/',
     expectedBase: 'https://api.snyk.io/',
     expectedV1: 'https://api.snyk.io/v1',
     expectedRest: 'https://api.snyk.io/rest',
     expectedRoot: 'https://snyk.io',
+    expectedApp: 'https://app.snyk.io',
   },
   {
     userInput: 'https://api.custom.snyk.io',
     expectedBase: 'https://api.custom.snyk.io',
     expectedV1: 'https://api.custom.snyk.io/v1',
     expectedRest: 'https://api.custom.snyk.io/rest',
     expectedRoot: 'https://custom.snyk.io',
+    expectedApp: 'https://app.custom.snyk.io',
   },
   {
     userInput: 'https://localhost:9000/',
     expectedBase: 'https://localhost:9000/',
     expectedV1: 'https://localhost:9000/v1',
     expectedRest: 'https://localhost:9000/rest',
     expectedRoot: 'https://localhost:9000',
+    expectedApp: 'https://localhost:9000',
   },
   {
     userInput: 'https://localhost:9000/api/v1',
     expectedBase: 'https://localhost:9000/api/',
     expectedV1: 'https://localhost:9000/api/v1',
     expectedRest: 'https://localhost:9000/rest',
     expectedRoot: 'https://localhost:9000',
+    expectedApp: 'https://localhost:9000',
   },
   {
     userInput: 'https://alpha:omega@localhost:9000',
     expectedBase: 'https://alpha:omega@localhost:9000',
     expectedV1: 'https://alpha:omega@localhost:9000/v1',
     expectedRest: 'https://alpha:omega@localhost:9000/rest',
     expectedRoot: 'https://localhost:9000',
+    expectedApp: 'https://localhost:9000',
   },
   {
     userInput: 'https://app.dev.snyk.io/api/v1',
     expectedBase: 'https://app.dev.snyk.io/api/',
     expectedV1: 'https://app.dev.snyk.io/api/v1',
     expectedRest: 'https://api.dev.snyk.io/rest',
     expectedRoot: 'https://app.dev.snyk.io',
+    expectedApp: 'https://app.dev.snyk.io',
   },
 ];
 
@@ -173,4 +186,12 @@ describe('CLI config - API URL', () => {
       });
     });
   });
+
+  describe('getAppUrl', () => {
+    urls.forEach((url) => {
+      it(`returns ROOT URL ${url.userInput}`, () => {
+        expect(getAppUrl(url.userInput)).toEqual(url.expectedApp);
+      });
+    });
+  });
 });
diff --git a/test/jest/unit/lib/formatters/iac-output/text/share-results.spec.ts b/test/jest/unit/lib/formatters/iac-output/text/share-results.spec.ts
@@ -1,10 +1,11 @@
 import { EOL } from 'os';
-import config from '../../../../../../../src/lib/config';
 import { formatShareResultsOutput } from '../../../../../../../src/lib/formatters/iac-output/text';
 import {
   colors,
   contentPadding,
 } from '../../../../../../../src/lib/formatters/iac-output/text/utils';
+import { getAppUrl } from '../../../../../../../src/lib/config/api-url';
+import config from '../../../../../../../src/lib/config';
 
 describe('formatShareResultsOutput', () => {
   it('returns the correct output', () => {
@@ -22,7 +23,7 @@ describe('formatShareResultsOutput', () => {
         EOL +
         contentPadding +
         'Your test results are available at: ' +
-        colors.title(`${config.ROOT}/org/${testOrgName}/projects`) +
+        colors.title(`${getAppUrl(config.API)}/org/${testOrgName}/projects`) +
         EOL +
         contentPadding +
         'under the name: ' +
