feat: [OSM-2902] Better support for comments in Dotnet global.json

nico-incubiq · nico-incubiq · commit 164618cf3b98 · 2025-06-11T17:37:04.000+01:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -124,7 +124,7 @@
     "snyk-mvn-plugin": "3.9.1",
     "snyk-nodejs-lockfile-parser": "2.1.0",
     "snyk-nodejs-plugin": "1.4.4",
-    "snyk-nuget-plugin": "2.7.15",
+    "snyk-nuget-plugin": "2.9.0",
     "snyk-php-plugin": "1.12.1",
     "snyk-policy": "4.1.5",
     "snyk-python-plugin": "2.7.0",
diff --git a/test/acceptance/workspaces/nuget-app-9-globaljson/dotnet_9.csproj b/test/acceptance/workspaces/nuget-app-9-globaljson/dotnet_9.csproj
@@ -0,0 +1,5 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <TargetFramework>net6.0</TargetFramework>
+  </PropertyGroup>
+</Project>
diff --git a/test/acceptance/workspaces/nuget-app-9-globaljson/global.json b/test/acceptance/workspaces/nuget-app-9-globaljson/global.json
@@ -0,0 +1,7 @@
+{
+  "comment": "Only update the version manually with major SDK updates, see https://dotnet.microsoft.com/en-us/download/dotnet.",
+  "sdk": {
+    "version": "6.0.100",
+    "rollForward": "latestMajor"
+  }
+}
diff --git a/test/acceptance/workspaces/nuget-app-9-globaljson/program.cs b/test/acceptance/workspaces/nuget-app-9-globaljson/program.cs
@@ -0,0 +1,8 @@
+using System;
+class TestFixture {
+    static public void Main(String[] args)
+    {
+      var client = new System.Net.Http.HttpClient();
+      Console.WriteLine("Hello, World!");
+    }
+}
diff --git a/test/jest/acceptance/snyk-test/basic-test-all-languages.spec.ts b/test/jest/acceptance/snyk-test/basic-test-all-languages.spec.ts
@@ -243,6 +243,10 @@ describe('`snyk test` of basic projects for each language/ecosystem', () => {
       fixture: 'nuget-app-8-with-multi-project and spaces',
       targetFile: 'dotnet_8_first.csproj',
     },
+    {
+      fixture: 'nuget-app-9-globaljson',
+      targetFile: 'dotnet_9.csproj',
+    },
   ])(
     'run `snyk test` on a nuget project using v2 dotnet runtime resolution logic for $fixture',
     async ({ fixture, targetFile }) => {
