Fixup: Push versioned docker image tags after publish

sitbon · sitbon · commit ff9b2606e341 · 2025-06-25T22:34:00.000-07:00
Signed-off-by: Phillip Sitbon &lt;phillip.sitbon@gmail.com&gt;
diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml
@@ -100,7 +100,8 @@ jobs:
     name: Push Dev Images
     runs-on: ubuntu-latest
 
-    needs: [build-dev-image, test-dev-image]
+    needs: build-dev-image
+    if: ${{ always() && needs.build-dev-image.result == 'success' && (needs.test-dev-image.result == 'success' || needs.test-dev-image.result == 'skipped') }}
 
     permissions:
       contents: read
@@ -173,34 +174,35 @@ jobs:
     name: Build and Push Image
     runs-on: ubuntu-latest
 
-    needs: [build-dev-image, test-dev-image]
+    needs: build-dev-image
+    if: ${{ always() && needs.build-dev-image.result == 'success' && (needs.test-dev-image.result == 'success' || needs.test-dev-image.result == 'skipped') }}
 
     permissions:
       contents: read
       packages: write
-    
+
     strategy:
       matrix:
         include:
           - target: pre
             suffix: "-pre"
           - target: pro
             suffix: ""
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      
+
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-      
+
       - name: Log in to Container Registry
         uses: docker/login-action@v3
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
-      
+
       - name: Extract Metadata
         id: meta
         uses: docker/metadata-action@v5
@@ -212,7 +214,7 @@ jobs:
             type=semver,pattern=v{{major}}.{{minor}}.{{patch}},pattern={{major}}.{{minor}}.{{patch}},suffix=${{ matrix.suffix }}
             type=semver,pattern=v{{major}}.{{minor}}.{{patch}},pattern={{major}}.{{minor}},suffix=${{ matrix.suffix }}
             type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' && matrix.target == 'pro' }}
-      
+
       - name: Build and push Docker image
         uses: docker/build-push-action@v6
         with:
@@ -231,7 +233,7 @@ jobs:
     name: Cleanup Untagged Images
     runs-on: ubuntu-latest
 
-    needs: [test-dev-image, build-and-push-image]
+    needs: [push-dev-image, build-and-push-image]
     if: ${{ github.event_name != 'pull_request' }}
 
     permissions:
