CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:39:04 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/saket/InboxRecyclerView.git
etag: W/"2c40f8af922294dc756ad511d36303fc"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=WX9lX2wyPeqcZoxo8NhUHm5TB8yfFFk4sDBpm0IIHSLy7PY3ZkJKPPHbl2D%2BvoOq4Pq0ccogklx25hcWBHm%2FxJaLaSc0Mial1Xr6SKGs8nY0B1tyqfzDKBAvT%2FWPa%2Bg4isNu9%2B33dDwOCMS%2BfIL6NvNa8%2FEVvmvBkxffHAznxm7FRxH%2BIWaexe%2FWjyIDnd1vt0BTxGZvCp5gc6IBF12rCC5tx9OyEwT0RqYIGqhib9N2H3WtooJ7D5v9KBj3CW6t%2FGQcJwToe77BOVYX%2BV5%2F0w%3D%3D--1IqpnFOr%2B75t4ck8--vwneef0GIEVdSyqF%2BZamEg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.803621681.1753403943; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:39:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:39:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CB54:17B6C0:4C0B6:77FC8:6882D227
Fix: item change animations get canceled by ItemExpandAnimator · saket/InboxRecyclerView@354e5c1 · GitHub
committed
Copy file name to clipboardExpand all lines: inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/ItemExpandAnimator.kt
Copy file name to clipboard
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 118
Commit 354e5c1

Saket Narayan
Fix: item change animations get canceled by ItemExpandAnimator
It's surprising that this bug flew under the radar for so long. ItemExpandAnimator registers a global layout listener on ExpandablePageLayout that was originally written to react to size changes and synchronize RecyclerView items with the page. As a side effect, it also used to override item add/remove/change/move animations. This commit modifies the implementation to ignore global layout callbacks unless the page's location or size changes.1 parent f3ca4b0 commit 354e5c1Copy full SHA for 354e5c1
File tree
Expand file treeCollapse file tree
2 files changed
+49
-30
lines changedFilter options
- inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation
Expand file treeCollapse file tree
2 files changed
+49
-30
lines changedinboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/ItemExpandAnimator.kt
Copy file name to clipboardExpand all lines: inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/ItemExpandAnimator.kt+10-30Lines changed: 10 additions & 30 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 | 1 |
| |
2 | 2 |
| |
3 |
| - | |
4 |
| - | |
5 | 3 |
| |
6 |
| - | |
7 | 4 |
| |
8 | 5 |
| |
9 | 6 |
| |
10 | 7 |
| |
11 | 8 |
| |
12 | 9 |
| |
13 | 10 |
| |
14 |
| - | |
15 |
| - | |
16 |
| - | |
17 |
| - | |
18 |
| - | |
19 |
| - | |
20 |
| - | |
21 |
| - | |
22 |
| - | |
23 |
| - | |
24 |
| - | |
25 |
| - | |
26 |
| - | |
27 |
| - | |
28 |
| - | |
29 |
| - | |
30 |
| - | |
31 |
| - | |
32 |
| - | |
33 |
| - | |
34 |
| - | |
35 |
| - | |
36 |
| - | |
37 | 11 |
| |
| 12 | + | |
38 | 13 |
| |
39 | 14 |
| |
40 | 15 |
| |
41 |
| - | |
42 |
| - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
43 | 20 |
| |
44 | 21 |
| |
45 | 22 |
| |
46 |
| - | |
47 |
| - | |
| 23 | + | |
| 24 | + | |
48 | 25 |
| |
49 | 26 |
| |
50 | 27 |
| |
| |||
57 | 34 |
| |
58 | 35 |
| |
59 | 36 |
| |
| 37 | + | |
| 38 | + | |
| 39 | + | |
60 | 40 |
| |
61 | 41 |
| |
62 | 42 |
| |
|
inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt
Copy file name to clipboard+39Lines changed: 39 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + |
You can’t perform that action at this time.
0 commit comments