| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 05:22:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=305.267988,conversation_content-fragment;desc="conversation_content fragment";dur=1068.668373,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=244.214655,nginx;desc="NGINX";dur=0.930976,glb;desc="GLB";dur=136.631926
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=WZuw4CnK0hNoU8gIumkPgdSYVflu%2BV1HcD20Z6zMSLYM4ipP4gkVm6O4vnl67RwckkHCIcg9u02%2ByI%2FsnJIyn6IOo3ZrypcEUDzH1d4W%2FpxMOJLE5Hf9PHsUwNuA3uRcSgFuLDXeQxXCmOHyp%2BE38dE47zQI4kXvVXbpuDZ0LXz1FDWhCkeG4ya4awJnRRTd248RY5%2FrwffC5TnOf0Oao5P5R3Gv8BrVGWJxyVk9%2BLWx5jDCW4fDn99628oZpv5lbV71OYF0rbXeUsJQ7XAD0w%3D%3D--9waygjTdKcyZ79u2--KNLAUOAg4Dj4UK5TxLr22w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1434616241.1760160136; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 05:22:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 05:22:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9FFA:8CC4A:3154B7:4686BB:68E9E988
Add support for rendering alerts in README by eth3lbert · Pull Request #11441 · rust-lang/crates.io · GitHub
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
June 26, 2025 15:28
eth3lbert
changed the title
Add support for rendering alerts in markdown
Add support for rendering alerts in README
Jun 26, 2025
eth3lbert
force-pushed
the
markdown-render-alert
branch
2 times, most recently
from
June 26, 2025 18:00
eth3lbert
added
the
C-enhancement ✨
Category: Adding new behavior or a change to the way an existing feature works
label
Jun 26, 2025
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
June 30, 2025 12:56
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
June 30, 2025 12:56
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 676
Add support for rendering alerts in README #11441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
5ab7ab3 to
364dd2b
Compare
eth3lbert
changed the title
eth3lbert
force-pushed
the
markdown-render-alert
branch
2 times, most recently
from
49e99ee to
0bec9ee
Compare
eth3lbert
added
the
C-enhancement ✨
|
Currently, alert icon support is handled via pure CSS for the following reasons:
There's also an alternative solution which doesn't require serving the SVG icon via CSS. This might require parsing the sanitized document and inserting the SVG into it. |
eth3lbert
commented
Jun 26, 2025
| fn text_with_forbidden_class_attribute() { | ||
| let text = "<p class='bad-class'>Hello World!</p>"; | ||
| assert_snapshot!(markdown_to_html(text, None, ""), @"<p>Hello World!</p>"); | ||
| assert_snapshot!(markdown_to_html(text, None, ""), @r#"<p class="">Hello World!</p>"#); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be caused by the allowed_classes. I'm not sure if there's any way to get around it.
|
LGTM, though in the screenshot it looks like there is a lot of padding at the bottom of the alert. is that intentional? I couldn't find anything in the CSS that would explicitly set it like this. 🤔 |
Ah, good catch! It shouldn't have a |
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
0bec9ee to
2c8ff86
Compare
eth3lbert
force-pushed
the
markdown-render-alert
branch
from
2c8ff86 to
26d3e61
Compare
|
Thanks for the review! All the feedback should be addressed now. (I also rebased to the latest) :D |
Turbo87
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks better, thanks! :)
tdelmas
added a commit
to tdelmas/typed_floats
that referenced
this pull request
Jul 14, 2025
Signed-off-by: GitHub <noreply@github.com>
GlenDC
added a commit
to plabayo/rama
that referenced
this pull request
Jul 23, 2025
tdelmas
added a commit
to tdelmas/typed_floats
that referenced
this pull request
Sep 20, 2025
Signed-off-by: GitHub <noreply@github.com>
tdelmas
added a commit
to tdelmas/typed_floats
that referenced
this pull request
Sep 20, 2025
Signed-off-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement ✨
Category: Adding new behavior or a change to the way an existing feature works
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR continues the work on #10429 and makes it functional by adding
allowed_classes. This ensures that the generated alert blocks won't be cleaned by the sanitizer. Tests have also been added to confirm everything works as expected.Thanks, @kbdharun, for the work on #10429.
preview:
