fix: make strip_leading_zeros_vec() work correctly

mrothNET · web-flow · commit 57e11c5829c3 · 2024-10-07T01:01:53.000+02:00
diff --git a/src/util.rs b/src/util.rs
@@ -83,9 +83,7 @@ pub fn strip_leading_zeros(bytes: &[u8]) -> &[u8] {
 #[inline]
 pub fn strip_leading_zeros_vec(bytes: &mut Vec<u8>) {
     if let Some(offset) = bytes.iter_mut().position(|b| b != &0) {
-        for i in 0..offset {
-            bytes.remove(i);
-        }
+        bytes.drain(..offset);
     }
 }
 
@@ -246,4 +244,11 @@ mod tests {
         let stripped = strip_leading_zeros(&buf);
         assert_eq!(stripped, &[]);
     }
+
+    #[test]
+    fn test_strip_leading_zeros_vec() {
+        let mut vec = vec![0, 0, 0, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
+        strip_leading_zeros_vec(&mut vec);
+        assert_eq!(vec, vec![1, 2, 3, 4, 5, 6, 7, 8, 9]);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,7 @@ pub fn strip_leading_zeros(bytes: &[u8]) -> &[u8] {`
`83`	`83`	`#[inline]`
`84`	`84`	`pub fn strip_leading_zeros_vec(bytes: &mut Vec<u8>) {`
`85`	`85`	`if let Some(offset) = bytes.iter_mut().position(\|b\| b != &0) {`
`86`		`- for i in 0..offset {`
`87`		`- bytes.remove(i);`
`88`		`- }`
	`86`	`+ bytes.drain(..offset);`
`89`	`87`	`}`
`90`	`88`	`}`
`91`	`89`
`@@ -246,4 +244,11 @@ mod tests {`
`246`	`244`	`let stripped = strip_leading_zeros(&buf);`
`247`	`245`	`assert_eq!(stripped, &[]);`
`248`	`246`	`}`
	`247`	`+`
	`248`	`+ #[test]`
	`249`	`+ fn test_strip_leading_zeros_vec() {`
	`250`	`+ let mut vec = vec![0, 0, 0, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9];`
	`251`	`+ strip_leading_zeros_vec(&mut vec);`
	`252`	`+ assert_eq!(vec, vec![1, 2, 3, 4, 5, 6, 7, 8, 9]);`
	`253`	`+ }`
`249`	`254`	`}`