fix: do some performance improvement

angelozerr · angelozerr · commit 80571c6e8ab9 · 2025-03-21T15:10:21.000+01:00
Signed-off-by: azerr &lt;azerr@redhat.com&gt;
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/LanguageServiceAccessor.java b/src/main/java/com/redhat/devtools/lsp4ij/LanguageServiceAccessor.java
@@ -267,8 +267,8 @@ public boolean hasAny(@NotNull VirtualFile file,
         // We get the Document instance now, to avoid creating a new Read Action thread to get it from the file.
         // The document instance is only used when the file is opened, to add
         // LSP document listener to manage didOpen, didChange, etc.
-        boolean writeAccessAllowed = !ApplicationManager.getApplication().isWriteAccessAllowed();
-        boolean readAccessAllowed = !ApplicationManager.getApplication().isWriteAccessAllowed();
+        boolean writeAccessAllowed = ApplicationManager.getApplication().isWriteAccessAllowed();
+        boolean readAccessAllowed = ApplicationManager.getApplication().isReadAccessAllowed();
         Document document = readAccessAllowed || (!writeAccessAllowed) ? LSPIJUtils.getDocument(file) : null;
 
         // Try to get document, languageId information (used by didOpen) for each matched language server wrapper
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/features/codeLens/UnresolvedCodeLensViewportContext.java b/src/main/java/com/redhat/devtools/lsp4ij/features/codeLens/UnresolvedCodeLensViewportContext.java
@@ -26,15 +26,15 @@
  * and refreshing the editor once the resolution is complete. This class tracks the
  * currently visible lines and ensures efficient refreshing through debounce logic.
  */
-public class UnresolvedCodeLensViewportContext implements Disposable  {
+public class UnresolvedCodeLensViewportContext implements Disposable {
 
     private static final long VIEWPORT_CHANGE_DELAY_MS = 500L; // Debounce delay before processing viewport changes
 
     private final @NotNull Editor editor;
     private int firstViewportLine;
     private int lastViewportLine;
     private long modificationStamp;
-    private Alarm scrollStopAlarm = new Alarm(Alarm.ThreadToUse.POOLED_THREAD, this);
+    private volatile Alarm scrollStopAlarm = null;
 
     /**
      * Initializes the context for managing unresolved code lens elements in a given editor.
@@ -79,15 +79,16 @@ public int getLastViewportLine() {
      * Resolves unresolved code lens elements in the current viewport and refreshes the editor accordingly.
      * If a previous refresh task is pending, it will be cancelled before scheduling a new one.
      *
-     * @param result             The unresolved code lens data to resolve.
-     * @param file             The associated PSI file containing the code.
+     * @param result            The unresolved code lens data to resolve.
+     * @param file              The associated PSI file containing the code.
      * @param firstViewportLine The first visible line in the editor's viewport.
      * @param lastViewportLine  The last visible line in the editor's viewport.
      */
     public void refreshCodeVision(@NotNull CodeLensDataResult result,
                                   @NotNull PsiFile file,
                                   int firstViewportLine,
                                   int lastViewportLine) {
+        var scrollStopAlarm = getScrollStopAlarm();
         scrollStopAlarm.cancelAllRequests();
         scrollStopAlarm.addRequest(() -> {
             if (isSameViewportRange(firstViewportLine, lastViewportLine)
@@ -96,11 +97,22 @@ public void refreshCodeVision(@NotNull CodeLensDataResult result,
                 // The viewport hasn't changed (no scrolling occurred) there are some codelens to resolve and file has not changed
                 // , so we proceed to refresh
                 EditorFeatureManager.getInstance(editor.getProject()).
-                    refreshEditorFeature(file.getVirtualFile(), EditorFeatureType.CODE_VISION, false);
+                        refreshEditorFeature(file.getVirtualFile(), EditorFeatureType.CODE_VISION, false);
             }
         }, VIEWPORT_CHANGE_DELAY_MS);
     }
 
+    private Alarm getScrollStopAlarm() {
+        if (scrollStopAlarm == null) {
+            synchronized (this) {
+                if (scrollStopAlarm == null) {
+                    scrollStopAlarm = new Alarm(Alarm.ThreadToUse.POOLED_THREAD, this);
+                }
+            }
+        }
+        return scrollStopAlarm;
+    }
+
     /**
      * Checks if the current viewport range matches the given range.
      *
@@ -114,14 +126,11 @@ private boolean isSameViewportRange(int firstViewportLine, int lastViewportLine)
 
     @Override
     public void dispose() {
-        if (scrollStopAlarm != null) {
-            scrollStopAlarm.cancelAllRequests();
-            scrollStopAlarm = null;
-        }
     }
 
     /**
      * Returns true if the file content has changed and false otherwise.
+     *
      * @param file the file.
      * @return true if the file content has changed and false otherwise.
      */
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/features/color/LSPColorProvider.java b/src/main/java/com/redhat/devtools/lsp4ij/features/color/LSPColorProvider.java
@@ -35,7 +35,6 @@
 import java.util.concurrent.CancellationException;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutionException;
-import java.util.concurrent.TimeoutException;
 import java.util.stream.Collectors;
 
 import static com.redhat.devtools.lsp4ij.internal.CompletableFutures.isDoneNormally;
@@ -60,8 +59,8 @@ protected void doCollect(@NotNull PsiFile psiFile,
         CompletableFuture<List<ColorData>> future = colorSupport.getColors(params);
 
         try {
-            // Wait until the future while 200ms and stop the wait if there are some ProcessCanceledException.
-            waitUntilDone(future, psiFile, 200);
+            // Wait until the future is done and stop the wait if there are some ProcessCanceledException.
+            waitUntilDone(future, psiFile);
             if (isDoneNormally(future)) {
 
                 // Collect color information
@@ -79,10 +78,6 @@ protected void doCollect(@NotNull PsiFile psiFile,
                                         toPresentation(list, factory))
                         );
             }
-        } catch (TimeoutException ignore) {
-            // the future which collects all textDocument/documentColor for all servers is not finished
-            // add it to the pending futures to refresh again the UI when this future will be finished.
-            pendingFutures.add(future);
         } catch (ProcessCanceledException ignore) {//Since 2024.2 ProcessCanceledException extends CancellationException so we can't use multicatch to keep backward compatibility
             //TODO delete block when minimum required version is 2024.2
         } catch (CancellationException ignore) {
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/features/formatting/LSPClientSideOnTypeFormattingTypedHandler.java b/src/main/java/com/redhat/devtools/lsp4ij/features/formatting/LSPClientSideOnTypeFormattingTypedHandler.java
@@ -14,7 +14,6 @@
 import com.intellij.codeInsight.editorActions.TypedHandlerDelegate;
 import com.intellij.openapi.editor.Document;
 import com.intellij.openapi.editor.Editor;
-import com.intellij.openapi.progress.ProcessCanceledException;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.TextRange;
 import com.intellij.openapi.util.text.StringUtil;
@@ -24,22 +23,22 @@
 import com.intellij.util.containers.ContainerUtil;
 import com.redhat.devtools.lsp4ij.LSPIJEditorUtils;
 import com.redhat.devtools.lsp4ij.LanguageServerItem;
-import com.redhat.devtools.lsp4ij.LanguageServersRegistry;
 import com.redhat.devtools.lsp4ij.LanguageServiceAccessor;
-import com.redhat.devtools.lsp4ij.ServerStatus;
 import com.redhat.devtools.lsp4ij.client.features.LSPFormattingFeature;
 import com.redhat.devtools.lsp4ij.client.features.LSPFormattingFeature.FormattingScope;
+import com.redhat.devtools.lsp4ij.client.indexing.ProjectIndexingManager;
 import com.redhat.devtools.lsp4ij.features.codeBlockProvider.LSPCodeBlockProvider;
 import com.redhat.devtools.lsp4ij.features.completion.LSPCompletionTriggerTypedHandler;
 import com.redhat.devtools.lsp4ij.features.selectionRange.LSPSelectionRangeSupport;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 import java.util.*;
-import java.util.concurrent.*;
+import java.util.concurrent.CompletableFuture;
 
 import static com.intellij.codeInsight.editorActions.ExtendWordSelectionHandlerBase.expandToWholeLinesWithBlanks;
 import static com.redhat.devtools.lsp4ij.internal.CompletableFutures.isDoneNormally;
+import static com.redhat.devtools.lsp4ij.internal.CompletableFutures.waitUntilDone;
 
 /**
  * Typed handler for LSP4IJ-managed files that performs automatic on-type formatting for specific keystrokes.
@@ -52,11 +51,6 @@ public Result charTyped(char charTyped,
                             @NotNull Project project,
                             @NotNull Editor editor,
                             @NotNull PsiFile file) {
-        if (!LanguageServersRegistry.getInstance().isFileSupported(file)) {
-            // The file is not associated to a language server
-            return super.charTyped(charTyped, project, editor, file);
-        }
-
         LSPFormattingFeature formattingFeature = getFormattingFeature(file);
         if (formattingFeature != null) {
             boolean rangeFormattingSupported = formattingFeature.isRangeFormattingSupported(file);
@@ -128,43 +122,36 @@ public Result charTyped(char charTyped,
 
     @Nullable
     private static LSPFormattingFeature getFormattingFeature(@NotNull PsiFile file) {
+        if (ProjectIndexingManager.isIndexingAll()) {
+            // while indexing, we do nothing
+            return null;
+        }
+        if (!hasLanguageServerSupportingOnlyFormatting(file)) {
+            // The file is not associated to a language server which supports only formatting
+            return null;
+        }
         Project project = file.getProject();
         VirtualFile virtualFile = file.getVirtualFile();
 
-        CompletableFuture<@NotNull List<LanguageServerItem>> languageServersFuture = LanguageServiceAccessor.getInstance(project).getLanguageServers(
-                virtualFile,
+        CompletableFuture<@NotNull List<LanguageServerItem>> future = LanguageServiceAccessor.getInstance(project)
+                .getLanguageServers(virtualFile,
                 // Client-side on-type formatting shouldn't trigger a language server to start
-                f -> (f.getServerStatus() == ServerStatus.started) &&
-                     f.getFormattingFeature().isEnabled(file) &&
-                     // Must support formatting
-                     f.getFormattingFeature().isFormattingSupported(file),
-                null
+                f -> f.getFormattingFeature().isEnabled(file),
+                f -> f.getFormattingFeature().isFormattingSupported(file)
         );
 
-        //noinspection TryWithIdenticalCatches
+        // Wait until the future while 500ms and stop the wait if there are some ProcessCanceledException.
         try {
-            // wait few ms to get formatting features to avoid freezing UI
-            // when server started and didOpen must occur.
-            languageServersFuture.get(500, TimeUnit.MILLISECONDS);
-        } catch (ProcessCanceledException e) {
-            return null;
-        } catch (CancellationException e) {
-            return null;
-        } catch (ExecutionException e) {
-            return null;
-        } catch (InterruptedException e) {
-            Thread.currentThread().interrupt();
-            return null;
-        } catch (TimeoutException e) {
+            waitUntilDone(future, file, 500);
+        } catch (Exception e) {
             return null;
         }
-
-        if (!isDoneNormally(languageServersFuture)) {
+        if (!isDoneNormally(future)) {
             return null;
         }
 
         // Just return the first matching language server, if any
-        List<LanguageServerItem> languageServers = languageServersFuture.getNow(Collections.emptyList());
+        List<LanguageServerItem> languageServers = future.getNow(Collections.emptyList());
         LanguageServerItem languageServer = ContainerUtil.getFirstItem(languageServers);
         return languageServer != null ? languageServer.getClientFeatures().getFormattingFeature() : null;
     }
@@ -345,4 +332,15 @@ private static void format(@NotNull Project project,
             CodeStyleManager.getInstance(project).reformatText(file, Collections.singletonList(textRange));
         }
     }
+
+    private static boolean hasLanguageServerSupportingOnlyFormatting(@NotNull PsiFile file) {
+        return LanguageServiceAccessor.getInstance(file.getProject())
+                .hasAny(file.getVirtualFile(), ls -> {
+                    var clientFeatures = ls.getClientFeatures();
+                    return clientFeatures.getFormattingFeature().isEnabled(file) &&
+                            clientFeatures.getFormattingFeature().isSupported(file) &&
+                            (!clientFeatures.getOnTypeFormattingFeature().isEnabled(file) ||
+                            !clientFeatures.getOnTypeFormattingFeature().isSupported(file));
+                });
+    }
 }
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/features/formatting/LSPServerSideOnTypeFormattingHelper.java b/src/main/java/com/redhat/devtools/lsp4ij/features/formatting/LSPServerSideOnTypeFormattingHelper.java
@@ -18,7 +18,8 @@
 import com.intellij.util.containers.ContainerUtil;
 import com.redhat.devtools.lsp4ij.LSPFileSupport;
 import com.redhat.devtools.lsp4ij.LSPIJUtils;
-import com.redhat.devtools.lsp4ij.LanguageServersRegistry;
+import com.redhat.devtools.lsp4ij.LanguageServiceAccessor;
+import com.redhat.devtools.lsp4ij.client.indexing.ProjectIndexingManager;
 import org.eclipse.lsp4j.DocumentOnTypeFormattingParams;
 import org.eclipse.lsp4j.FormattingOptions;
 import org.eclipse.lsp4j.Position;
@@ -58,8 +59,11 @@ private LSPServerSideOnTypeFormattingHelper() {
     static boolean applyOnTypeFormatting(char charTyped,
                                          @NotNull Editor editor,
                                          @NotNull PsiFile file) {
-        if (!LanguageServersRegistry.getInstance().isFileSupported(file)) {
-            // The file is not associated to a language server
+        if (ProjectIndexingManager.isIndexingAll()) {
+            return false;
+        }
+        if (!hasLanguageServerSupportingOnTypeFormatting(file)) {
+            // The file is not associated to a language server which supports on type formatting
             return false;
         }
         // If so, issue a request for on-type formatting
@@ -102,4 +106,12 @@ static boolean applyOnTypeFormatting(char charTyped,
         LSPIJUtils.applyEdits(editor, document, textEdits);
         return true;
     }
+
+    private static boolean hasLanguageServerSupportingOnTypeFormatting(@NotNull PsiFile file) {
+        return LanguageServiceAccessor.getInstance(file.getProject())
+                .hasAny(file.getVirtualFile(), ls -> ls.getClientFeatures()
+                        .getOnTypeFormattingFeature()
+                        .isSupported(file));
+    }
+
 }
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/features/semanticTokens/viewProvider/LSPSemanticTokensFileViewProviderHelper.java b/src/main/java/com/redhat/devtools/lsp4ij/features/semanticTokens/viewProvider/LSPSemanticTokensFileViewProviderHelper.java
@@ -21,6 +21,7 @@
 import com.intellij.util.containers.ContainerUtil;
 import com.redhat.devtools.lsp4ij.LSPIJUtils;
 import com.redhat.devtools.lsp4ij.client.features.EditorBehaviorFeature;
+import com.redhat.devtools.lsp4ij.client.indexing.ProjectIndexingManager;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -55,7 +56,7 @@ private PsiFile getFile() {
 
     @Override
     public boolean isEnabled() {
-        return getFile() != null;
+        return !ProjectIndexingManager.isIndexingAll() && getFile() != null;
     }
 
     @Override
