Merge pull request #5037 from garrisonhh/fix-gaussian-blur

raysan5 · web-flow · commit 20a07a65d7b5 · 2025-07-10T19:06:34.000+02:00
[rtextures] fix integer overflow in cast for `ImageBlurGaussian`
diff --git a/src/rtextures.c b/src/rtextures.c
@@ -2217,9 +2217,9 @@ void ImageBlurGaussian(Image *image, int blurSize)
         else if (pixelsCopy1[i].w <= 255.0f)
         {
             float alpha = (float)pixelsCopy1[i].w/255.0f;
-            pixels[i].r = (unsigned char)((float)pixelsCopy1[i].x/alpha);
-            pixels[i].g = (unsigned char)((float)pixelsCopy1[i].y/alpha);
-            pixels[i].b = (unsigned char)((float)pixelsCopy1[i].z/alpha);
+            pixels[i].r = (unsigned char)fminf((float)pixelsCopy1[i].x/alpha, 255.0);
+            pixels[i].g = (unsigned char)fminf((float)pixelsCopy1[i].y/alpha, 255.0);
+            pixels[i].b = (unsigned char)fminf((float)pixelsCopy1[i].z/alpha, 255.0);
             pixels[i].a = (unsigned char) pixelsCopy1[i].w;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -2217,9 +2217,9 @@ void ImageBlurGaussian(Image *image, int blurSize)`
`2217`	`2217`	`else if (pixelsCopy1[i].w <= 255.0f)`
`2218`	`2218`	`{`
`2219`	`2219`	`float alpha = (float)pixelsCopy1[i].w/255.0f;`
`2220`		`- pixels[i].r = (unsigned char)((float)pixelsCopy1[i].x/alpha);`
`2221`		`- pixels[i].g = (unsigned char)((float)pixelsCopy1[i].y/alpha);`
`2222`		`- pixels[i].b = (unsigned char)((float)pixelsCopy1[i].z/alpha);`
	`2220`	`+ pixels[i].r = (unsigned char)fminf((float)pixelsCopy1[i].x/alpha, 255.0);`
	`2221`	`+ pixels[i].g = (unsigned char)fminf((float)pixelsCopy1[i].y/alpha, 255.0);`
	`2222`	`+ pixels[i].b = (unsigned char)fminf((float)pixelsCopy1[i].z/alpha, 255.0);`
`2223`	`2223`	`pixels[i].a = (unsigned char) pixelsCopy1[i].w;`
`2224`	`2224`	`}`
`2225`	`2225`	`}`